yegor256/sixnines

View on GitHub
objects/endpoint.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method ping has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def ping(count, proxies = [''])
    start = Time.now
    h = to_h
    code, body, log = ProxiedResource.new(
      CountedResource.new(
Severity: Major
Found in objects/endpoint.rb - About 2 hrs to fix

    Method ping has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def ping(count, proxies = [''])
        start = Time.now
        h = to_h
        code, body, log = ProxiedResource.new(
          CountedResource.new(
    Severity: Minor
    Found in objects/endpoint.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method favicon has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def favicon(body)
        xml = Nokogiri::HTML(body)
        links = xml.xpath('/html/head/link[@rel="shortcut icon"]/@href')
        uri = to_h[:uri]
        raise "Favicon URI can't be nil in the endpoint" if uri.nil?
    Severity: Minor
    Found in objects/endpoint.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status