Sign upLogin

yfix/yf

View on GitHub
Star
.dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php

Summary

Maintainability
F
6 days
Test Coverage

File class_db_real_installer_mysql_test.Test.php has 318 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

require_once __DIR__ . '/db_real_abstract.php';

/**
Severity: Minor
Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php - About 3 hrs to fix

    Method test_yf_db_installer_sharding has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function test_yf_db_installer_sharding()
    {
        $bak['ERROR_AUTO_REPAIR'] = self::db()->ERROR_AUTO_REPAIR;
        self::db()->ERROR_AUTO_REPAIR = true;
    Severity: Major
    Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php - About 2 hrs to fix

      Function _fix_sql_php has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _fix_sql_php($sql_php)
    {
        $innodb_has_fulltext = self::_innodb_has_fulltext();
        if ( ! $innodb_has_fulltext) {
            // Remove fulltext indexes from db structure before creating table
      Severity: Minor
      Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method test_yf_db_installer_alter_table has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function test_yf_db_installer_alter_table()
    {
        $bak['ERROR_AUTO_REPAIR'] = self::db()->ERROR_AUTO_REPAIR;
        self::db()->ERROR_AUTO_REPAIR = true;
      Severity: Minor
      Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php - About 1 hr to fix

        Method test_yf_db_installer_basic has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function test_yf_db_installer_basic()
    {
        if ($this->_need_skip_test(__FUNCTION__)) {
            return;
        }
        Severity: Minor
        Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php - About 1 hr to fix

          Method test_yf_db_installer_create_missing_table has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function test_yf_db_installer_create_missing_table()
    {
        $bak['ERROR_AUTO_REPAIR'] = self::db()->ERROR_AUTO_REPAIR;
        self::db()->ERROR_AUTO_REPAIR = true;
          Severity: Minor
          Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php - About 1 hr to fix

            Method _fix_sql_php has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function _fix_sql_php($sql_php)
    {
        $innodb_has_fulltext = self::_innodb_has_fulltext();
        if ( ! $innodb_has_fulltext) {
            // Remove fulltext indexes from db structure before creating table
            Severity: Minor
            Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php - About 1 hr to fix

              Method test_query_stats_override has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function test_query_stats_override()
    {
        $bak['ERROR_AUTO_REPAIR'] = self::db()->ERROR_AUTO_REPAIR;
        self::db()->ERROR_AUTO_REPAIR = true;
              Severity: Minor
              Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php - About 1 hr to fix

                Function test_yf_db_installer_basic has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function test_yf_db_installer_basic()
    {
        if ($this->_need_skip_test(__FUNCTION__)) {
            return;
        }
                Severity: Minor
                Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function test_yf_db_installer_create_missing_table has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function test_yf_db_installer_create_missing_table()
    {
        $bak['ERROR_AUTO_REPAIR'] = self::db()->ERROR_AUTO_REPAIR;
        self::db()->ERROR_AUTO_REPAIR = true;
                Severity: Minor
                Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        foreach ((array) $tables_php as $name => $sql_php) {
            $table = $db_prefix . $name;
            $sql_php = $this->_fix_sql_php($sql_php);
            $this->assertTrue(is_array($sql_php) && count((array) $sql_php) && $sql_php);
            $this->assertFalse((bool) self::utils()->table_exists(self::table_name($table)));
                Severity: Major
                Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php and 1 other location - About 1 day to fix
                .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php on lines 336..356

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 377.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        foreach ((array) $tables_php as $name => $sql_php) {
            $table = $db_prefix . $name;
            $sql_php = $this->_fix_sql_php($sql_php);
            $this->assertTrue(is_array($sql_php) && count((array) $sql_php) && $sql_php);
            $this->assertFalse((bool) self::utils()->table_exists(self::table_name($table)));
                Severity: Major
                Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php and 1 other location - About 1 day to fix
                .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php on lines 263..283

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 377.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function _fix_sql_php($sql_php)
    {
        $innodb_has_fulltext = self::_innodb_has_fulltext();
        if ( ! $innodb_has_fulltext) {
            // Remove fulltext indexes from db structure before creating table
                Severity: Major
                Found in .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php and 1 other location - About 1 day to fix
                .dev/tests/functional/model/class_model_sakila_test.Test.php on lines 40..72

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 289.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status