File class_model_bears_test.Test.php
has 600 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
require_once dirname(__DIR__) . '/db_real_abstract.php';
/**
Method create_data
has 179 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function create_data()
{
try {
// bear 1 is named Lawly. She is extremely dangerous. Especially when hungry.
$bear_lawly = bear::create([
Method test_query_models
has 76 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function test_query_models()
{
if ($this->_need_skip_test(__FUNCTION__)) {
return;
}
Method create_models
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function create_models()
{
try {
$this->assertFalse(class_exists('bears'));
$this->assertFalse(class_exists('fish'));
Method test_many_to_many
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function test_many_to_many()
{
if ($this->_need_skip_test(__FUNCTION__)) {
return;
}
Method create_tables
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function create_tables()
{
try {
self::utils()->create_table('bears', function ($t) {
$t->increments('id')
Method test_one_to_one
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function test_one_to_one()
{
if ($this->_need_skip_test(__FUNCTION__)) {
return;
}
Method create_models_alternate_methods
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function create_models_alternate_methods()
{
try {
// Method 2
$bear_cool1 = model('bear')->create([
Identical blocks of code found in 3 locations. Consider refactoring. Open
public static function setUpBeforeClass() : void
{
self::$_bak['DB_DRIVER'] = self::$DB_DRIVER;
self::$DB_DRIVER = 'mysqli';
self::_connect();
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 153.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76