Sign upLogin

yfix/yf

View on GitHub
Star
.dev/tests/functional/model/class_model_sakila_test.Test.php

Summary

Maintainability
D
3 days
Test Coverage

Function test_load_fixtures has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function test_load_fixtures()
    {
        if ($this->_need_skip_test(__FUNCTION__)) {
            return;
        }
Severity: Minor
Found in .dev/tests/functional/model/class_model_sakila_test.Test.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method test_load_fixtures has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_load_fixtures()
    {
        if ($this->_need_skip_test(__FUNCTION__)) {
            return;
        }
Severity: Major
Found in .dev/tests/functional/model/class_model_sakila_test.Test.php - About 2 hrs to fix

    Function _fix_sql_php has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function _fix_sql_php($sql_php)
    {
        $innodb_has_fulltext = self::_innodb_has_fulltext();
        if ( ! $innodb_has_fulltext) {
            // Remove fulltext indexes from db structure before creating table
    Severity: Minor
    Found in .dev/tests/functional/model/class_model_sakila_test.Test.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method test_sakila_basic has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function test_sakila_basic()
    {
        if ($this->_need_skip_test(__FUNCTION__)) {
            return;
        }
    Severity: Minor
    Found in .dev/tests/functional/model/class_model_sakila_test.Test.php - About 1 hr to fix

      Method _fix_sql_php has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _fix_sql_php($sql_php)
    {
        $innodb_has_fulltext = self::_innodb_has_fulltext();
        if ( ! $innodb_has_fulltext) {
            // Remove fulltext indexes from db structure before creating table
      Severity: Minor
      Found in .dev/tests/functional/model/class_model_sakila_test.Test.php - About 1 hr to fix

        Function test_sakila_basic has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function test_sakila_basic()
    {
        if ($this->_need_skip_test(__FUNCTION__)) {
            return;
        }
        Severity: Minor
        Found in .dev/tests/functional/model/class_model_sakila_test.Test.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function _fix_sql_php($sql_php)
    {
        $innodb_has_fulltext = self::_innodb_has_fulltext();
        if ( ! $innodb_has_fulltext) {
            // Remove fulltext indexes from db structure before creating table
        Severity: Major
        Found in .dev/tests/functional/model/class_model_sakila_test.Test.php and 1 other location - About 1 day to fix
        .dev/tests/functional/db/class_db_real_installer_mysql_test.Test.php on lines 35..67

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 289.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            public static function setUpBeforeClass() : void
    {
        self::$_bak['DB_DRIVER'] = self::$DB_DRIVER;
        self::$DB_DRIVER = 'mysqli';
        self::_connect();
        Severity: Major
        Found in .dev/tests/functional/model/class_model_sakila_test.Test.php and 2 other locations - About 3 hrs to fix
        .dev/tests/functional/model/class_model_basic_test.Test.php on lines 18..31
        .dev/tests/functional/model/class_model_bears_test.Test.php on lines 18..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 153.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status