Sign upLogin

yfix/yf

View on GitHub
Star
plugins/admin/admin_modules/yf_admin.class.php

Summary

Maintainability
D
2 days
Test Coverage

File yf_admin.class.php has 380 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * Admin users manager.
 *
Severity: Minor
Found in plugins/admin/admin_modules/yf_admin.class.php - About 5 hrs to fix

    Method ajax has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function ajax($force_id = false)
    {
        $id = (int) ($force_id ?: $_GET['id']);
        $admin = from(self::table)->whereid($id)->get();
        if ( ! $id || ! $admin) {
    Severity: Major
    Found in plugins/admin/admin_modules/yf_admin.class.php - About 3 hrs to fix

      Function _get_admin_daily_info has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _get_admin_daily_info($sql, $days = 60, $admin_ids = [])
    {
        if ( ! $admin_ids) {
            return false;
        }
      Severity: Minor
      Found in plugins/admin/admin_modules/yf_admin.class.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method show has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function show()
    {
        $quick_filter = $this->_show_quick_filter();
        return
            '<div class="col-md-12">' .
      Severity: Major
      Found in plugins/admin/admin_modules/yf_admin.class.php - About 2 hrs to fix

        Function ajax has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function ajax($force_id = false)
    {
        $id = (int) ($force_id ?: $_GET['id']);
        $admin = from(self::table)->whereid($id)->get();
        if ( ! $id || ! $admin) {
        Severity: Minor
        Found in plugins/admin/admin_modules/yf_admin.class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method edit has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function edit()
    {
        $id = (int) ($_GET['id']);
        if ( ! $id) {
            return _e('Wrong id');
        Severity: Minor
        Found in plugins/admin/admin_modules/yf_admin.class.php - About 1 hr to fix

          Method _get_admin_daily_info has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function _get_admin_daily_info($sql, $days = 60, $admin_ids = [])
    {
        if ( ! $admin_ids) {
            return false;
        }
          Severity: Minor
          Found in plugins/admin/admin_modules/yf_admin.class.php - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function _get_admin_daily_auths($admin_ids = [])
    {
        $days = 60;
        $min_time = time() - $days * 86400;
        $sql = select('admin_id', 'FROM_UNIXTIME(`date`, "%Y-%m-%d") AS d', 'COUNT(*) AS c')
            Severity: Major
            Found in plugins/admin/admin_modules/yf_admin.class.php and 1 other location - About 1 hr to fix
            plugins/admin/admin_modules/yf_admin.class.php on lines 280..290

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function _get_admin_daily_visits($admin_ids = [])
    {
        $days = 60;
        $min_time = time() - $days * 86400;
        $sql = select('admin_id', 'FROM_UNIXTIME(`date`, "%Y-%m-%d") AS d', 'COUNT(*) AS c')
            Severity: Major
            Found in plugins/admin/admin_modules/yf_admin.class.php and 1 other location - About 1 hr to fix
            plugins/admin/admin_modules/yf_admin.class.php on lines 295..304

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status