Sign upLogin

yfix/yf

View on GitHub
Star
plugins/api/classes/yf_api.class.php

Summary

Maintainability
F
4 days
Test Coverage

Function _request has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

    public function _request($url, $post = null, $options = null)
    {
        // import options
        is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
        // options
Severity: Minor
Found in plugins/api/classes/yf_api.class.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File yf_api.class.php has 509 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/***
 *  module: api
 *
Severity: Major
Found in plugins/api/classes/yf_api.class.php - About 1 day to fix

    Method _request has 175 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function _request($url, $post = null, $options = null)
    {
        // import options
        is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
        // options
    Severity: Major
    Found in plugins/api/classes/yf_api.class.php - About 7 hrs to fix

      yf_api has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class yf_api
{
    public $API_SSL_VERIFY = true;
    public $JSON_VULNERABILITY_PROTECTION = true;
    public $ROBOT_NONE = true;
      Severity: Minor
      Found in plugins/api/classes/yf_api.class.php - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

                if (@$_is_response_raw) {
            $result = $body;
        } else {
            switch (true) {
                case  @$_is_response_json || strpos($content_type, 'application/json') === 0:
        Severity: Critical
        Found in plugins/api/classes/yf_api.class.php - About 1 hr to fix

          Method _init has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function _init()
    {
        ini_set('html_errors', 0);
        // ob_start();
        $class = &$this->class;
          Severity: Minor
          Found in plugins/api/classes/yf_api.class.php - About 1 hr to fix

            Function _send_http_status has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function _send_http_status($code = null, $status = null)
    {
        $code = (int) $code;
        $protocol = null;
        $status = null;
            Severity: Minor
            Found in plugins/api/classes/yf_api.class.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _init has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function _init()
    {
        ini_set('html_errors', 0);
        // ob_start();
        $class = &$this->class;
            Severity: Minor
            Found in plugins/api/classes/yf_api.class.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method _send_http_status has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function _send_http_status($code = null, $status = null)
    {
        $code = (int) $code;
        $protocol = null;
        $status = null;
            Severity: Minor
            Found in plugins/api/classes/yf_api.class.php - About 1 hr to fix

              Function _cache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function _cache( $options = null ) {
        // import options
        is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
        $h = [];
        // none
              Severity: Minor
              Found in plugins/api/classes/yf_api.class.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _ip_filter_valid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function _ip_filter_valid($ip_filter)
    {
        if ( ! is_array($ip_filter)) {
            return  false;
        }
              Severity: Minor
              Found in plugins/api/classes/yf_api.class.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return  [$status, $result];
              Severity: Major
              Found in plugins/api/classes/yf_api.class.php - About 30 mins to fix

                Function _check_ip has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function _check_ip($options = null)
    {
        // import options
        is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
        // filter
                Severity: Minor
                Found in plugins/api/classes/yf_api.class.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function _ip($options = null)
    {
        if ( ! empty($_SERVER['HTTP_X_FORWARDED_FOR'])) {
            $ips = explode(',', $_SERVER['HTTP_X_FORWARDED_FOR']);
            $ip = reset($ips);
                Severity: Major
                Found in plugins/api/classes/yf_api.class.php and 1 other location - About 1 hr to fix
                plugins/user/classes/yf_online_users.class.php on lines 79..92

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 108.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status