Sign upLogin

yfix/yf

View on GitHub
Star
plugins/assets/admin_modules/yf_manage_assets.class.php

Summary

Maintainability
F
3 days
Test Coverage

Function search_used has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function search_used()
    {
        $exclude_paths = [
            '*/.git/*',
            '*/.dev/*',
Severity: Minor
Found in plugins/assets/admin_modules/yf_manage_assets.class.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function combine has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function combine()
    {
        $assets = clone _class('assets');
        $assets->clean_all();
        $assets->ADD_IS_DIRECT_OUT = false;
Severity: Minor
Found in plugins/assets/admin_modules/yf_manage_assets.class.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method search_used has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function search_used()
    {
        $exclude_paths = [
            '*/.git/*',
            '*/.dev/*',
Severity: Major
Found in plugins/assets/admin_modules/yf_manage_assets.class.php - About 2 hrs to fix

    Method combine has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function combine()
    {
        $assets = clone _class('assets');
        $assets->clean_all();
        $assets->ADD_IS_DIRECT_OUT = false;
    Severity: Minor
    Found in plugins/assets/admin_modules/yf_manage_assets.class.php - About 1 hr to fix

      Function cache_fill has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function cache_fill()
    {
        $this->cache_purge();
        // TODO: use temp dir while caching
        // TODO: verify that all files are available
      Severity: Minor
      Found in plugins/assets/admin_modules/yf_manage_assets.class.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method cache_fill has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function cache_fill()
    {
        $this->cache_purge();
        // TODO: use temp dir while caching
        // TODO: verify that all files are available
      Severity: Minor
      Found in plugins/assets/admin_modules/yf_manage_assets.class.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                foreach ((array) $raw_in_php as $path => $matches) {
            $lines = file($path);
            foreach ((array) $matches as $raw) {
                preg_match($regex_php, $raw, $m);
                $name = trim(trim(trim($m['name']), '"\''));
        Severity: Major
        Found in plugins/assets/admin_modules/yf_manage_assets.class.php and 1 other location - About 5 hrs to fix
        plugins/assets/admin_modules/yf_manage_assets.class.php on lines 93..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 195.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                foreach ((array) $raw_in_tpl as $path => $matches) {
            $lines = file($path);
            foreach ((array) $matches as $raw) {
                preg_match($regex_tpl, $raw, $m);
                $name = trim(trim(trim($m['name']), '"\''));
        Severity: Major
        Found in plugins/assets/admin_modules/yf_manage_assets.class.php and 1 other location - About 5 hrs to fix
        plugins/assets/admin_modules/yf_manage_assets.class.php on lines 76..90

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 195.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                return html()->module_menu($this, [
            ['/@object/cache_info/', 'Cache info', 'fa fa-info'],
            ['/@object/cache_purge/', 'Cache purge', 'fa fa-recycle'],
            ['/@object/cache_fill/', 'Cache fill', 'fa fa-refresh'],
            ['/@object/combine/', 'Combine', 'fa fa-rocket'],
        Severity: Minor
        Found in plugins/assets/admin_modules/yf_manage_assets.class.php and 1 other location - About 40 mins to fix
        plugins/shop/modules/yf_shop.class.php on lines 517..525

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status