Sign upLogin

yfix/yf

View on GitHub
Star
plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php

Summary

Maintainability
F
3 days
Test Coverage

File yf_ck_file_browser.class.php has 465 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class yf_ck_file_browser
{
    public $TOP_DIR = '/uploads/';
Severity: Minor
Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 7 hrs to fix

    Method _data has 92 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function _data($id)
    {
        if (strpos($id, ':')) {
            $id = array_map([$this, 'id'], explode(':', $id));
            return [
    Severity: Major
    Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 3 hrs to fix

      Function _data has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _data($id)
    {
        if (strpos($id, ':')) {
            $id = array_map([$this, 'id'], explode(':', $id));
            return [
      Severity: Minor
      Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      yf_ck_file_browser has 26 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class yf_ck_file_browser
{
    public $TOP_DIR = '/uploads/';
    public $WRITABLE_DIR = '/uploads/ck_browser/';
    public $ALLOWED_EXTS = [
      Severity: Minor
      Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 3 hrs to fix

        Function _lst has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

            public function _lst($id, $with_root = false)
    {
        $dir = $this->_path($id);
        $res = [];
        foreach (glob(rtrim($dir, '/') . '/*') as $f) {
        Severity: Minor
        Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function upload_file has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function upload_file()
    {
        no_graphics(true);
        if ( ! MAIN_TYPE_ADMIN) {
            return print 'access denied';
        Severity: Minor
        Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method edit has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function edit()
    {
        if ( ! $this->ENABLED_IMG_EDIT) {
            return false;
        }
        Severity: Minor
        Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 1 hr to fix

          Method _lst has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function _lst($id, $with_root = false)
    {
        $dir = $this->_path($id);
        $res = [];
        foreach (glob(rtrim($dir, '/') . '/*') as $f) {
          Severity: Minor
          Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 1 hr to fix

            Method upload_file has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function upload_file()
    {
        no_graphics(true);
        if ( ! MAIN_TYPE_ADMIN) {
            return print 'access denied';
            Severity: Minor
            Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 1 hr to fix

              Function delete_img has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function delete_img()
    {
        $res = [];
        if ($this->ENABLED_IMG_DELETE && is_ajax() && is_post() && ! empty($_POST['path'])) {
            $fs_path = parse_url($_POST['path'], PHP_URL_PATH);
              Severity: Minor
              Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function edit has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function edit()
    {
        if ( ! $this->ENABLED_IMG_EDIT) {
            return false;
        }
              Severity: Minor
              Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return common()->show_messages()
            . '<br />path: ' . _prepare_html($title) . ', size: ' . filesize($target)
            . '<br /><a href="' . $web_path . '" target="_blank"><img src="' . $web_path . '" style="max-width: 200px; max-height: 200px;"></a>'
            . '<br /><br />' . a(['href' => '/@object/show/' . urlencode($title), 'title' => 'Go Next', 'target' => '']);
              Severity: Major
              Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 30 mins to fix

                Function _rename has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function _rename($id, $name)
    {
        $dir = $this->_path($id);
        if ($dir === $this->base) {
            throw new Exception('Cannot rename root');
                Severity: Minor
                Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _copy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function _copy($id, $par)
    {
        $dir = $this->_path($id);
        $par = $this->_path($par);
        $new = explode('/', $dir);
                Severity: Minor
                Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function copy_node()
    {
        $node = isset($_GET['id']) && $_GET['id'] !== '#' ? $_GET['id'] : '/';
        $parn = isset($_GET['parent']) && $_GET['parent'] !== '#' ? $_GET['parent'] : '/';
        $rslt = $this->_copy($node, $parn);
                Severity: Minor
                Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php and 1 other location - About 55 mins to fix
                plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php on lines 90..96

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 99.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function move_node()
    {
        $node = isset($_GET['id']) && $_GET['id'] !== '#' ? $_GET['id'] : '/';
        $parn = isset($_GET['parent']) && $_GET['parent'] !== '#' ? $_GET['parent'] : '/';
        $rslt = $this->_move($node, $parn);
                Severity: Minor
                Found in plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php and 1 other location - About 55 mins to fix
                plugins/ckeditor/admin_modules/yf_ck_file_browser.class.php on lines 99..105

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 99.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status