Sign upLogin

yfix/yf

View on GitHub
Star
plugins/comments/modules/yf_comments.class.php

Summary

Maintainability
F
3 days
Test Coverage

File yf_comments.class.php has 398 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * Comments handler.
 *
Severity: Minor
Found in plugins/comments/modules/yf_comments.class.php - About 5 hrs to fix

    Method _show_for_object_tree has 114 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function _show_for_object_tree($params = [])
    {
        $OBJECT_NAME = ! empty($params['object_name']) ? $params['object_name'] : $_GET['object'];
        $OBJECT_ID = ! empty($params['object_id']) ? (int) ($params['object_id']) : (int) ($_GET['id']);
        $STPL_NAME_MAIN = ! empty($params['stpl_main']) ? $params['stpl_main'] : 'comments/main_tree';
    Severity: Major
    Found in plugins/comments/modules/yf_comments.class.php - About 4 hrs to fix

      Function _show_for_object_tree has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _show_for_object_tree($params = [])
    {
        $OBJECT_NAME = ! empty($params['object_name']) ? $params['object_name'] : $_GET['object'];
        $OBJECT_ID = ! empty($params['object_id']) ? (int) ($params['object_id']) : (int) ($_GET['id']);
        $STPL_NAME_MAIN = ! empty($params['stpl_main']) ? $params['stpl_main'] : 'comments/main_tree';
      Severity: Minor
      Found in plugins/comments/modules/yf_comments.class.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _show_for_object has 102 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _show_for_object($params = [])
    {
        if ($this->USE_TREE_MODE) {
            return $this->_show_for_object_tree($params);
        }
      Severity: Major
      Found in plugins/comments/modules/yf_comments.class.php - About 4 hrs to fix

        Function _show_for_object has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
        Open

            public function _show_for_object($params = [])
    {
        if ($this->USE_TREE_MODE) {
            return $this->_show_for_object_tree($params);
        }
        Severity: Minor
        Found in plugins/comments/modules/yf_comments.class.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _sort_to_tree has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            public function _sort_to_tree($comment, $level = 0)
    {
        if (empty($comment)) {
            return false;
        }
        Severity: Minor
        Found in plugins/comments/modules/yf_comments.class.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method view_unread has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function view_unread()
    {
        if (empty(main()->USER_ID)) {
            return;
        }
        Severity: Minor
        Found in plugins/comments/modules/yf_comments.class.php - About 1 hr to fix

          Function view_unread has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function view_unread()
    {
        if (empty(main()->USER_ID)) {
            return;
        }
          Severity: Minor
          Found in plugins/comments/modules/yf_comments.class.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _get_num_comments has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function _get_num_comments($params = [])
    {
        $OBJECT_NAME = ! empty($params['object_name']) ? $params['object_name'] : $_GET['object'];
        $OBJECTS_IDS = ! empty($params['objects_ids']) ? $params['objects_ids'] : '';
        if (empty($OBJECTS_IDS)) {
          Severity: Minor
          Found in plugins/comments/modules/yf_comments.class.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function _format_text($body = '')
    {
        if (empty($body)) {
            return '';
        }
          Severity: Major
          Found in plugins/comments/modules/yf_comments.class.php and 1 other location - About 1 hr to fix
          plugins/common/classes/common/yf_preview.class.php on lines 95..117

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                      if ($delete_allowed_check_method) {
                $m = $this->_delete_allowed_method;
                $delete_allowed = (bool) module($_GET['object'])->$m([
                    'user_id' => $comment_info['user_id'],
                    'object_id' => $comment_info['object_id'],
          Severity: Major
          Found in plugins/comments/modules/yf_comments.class.php and 3 other locations - About 45 mins to fix
          plugins/comments/modules/yf_comments.class.php on lines 128..136
          plugins/comments/modules/yf_comments.class.php on lines 259..267
          plugins/comments/modules/yf_comments.class.php on lines 268..276

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                      if ($edit_allowed_check_method) {
                $m = $this->_edit_allowed_method;
                $edit_allowed = (bool) module($_GET['object'])->$m([
                    'user_id' => $comment_info['user_id'],
                    'object_id' => $comment_info['object_id'],
          Severity: Major
          Found in plugins/comments/modules/yf_comments.class.php and 3 other locations - About 45 mins to fix
          plugins/comments/modules/yf_comments.class.php on lines 128..136
          plugins/comments/modules/yf_comments.class.php on lines 137..145
          plugins/comments/modules/yf_comments.class.php on lines 268..276

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                      if ($edit_allowed_check_method) {
                $m = $this->_edit_allowed_method;
                $edit_allowed = (bool) module($_GET['object'])->$m([
                    'user_id' => $comment_info['user_id'],
                    'object_id' => $comment_info['object_id'],
          Severity: Major
          Found in plugins/comments/modules/yf_comments.class.php and 3 other locations - About 45 mins to fix
          plugins/comments/modules/yf_comments.class.php on lines 137..145
          plugins/comments/modules/yf_comments.class.php on lines 259..267
          plugins/comments/modules/yf_comments.class.php on lines 268..276

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                      if ($delete_allowed_check_method) {
                $m = $this->_delete_allowed_method;
                $delete_allowed = (bool) module($_GET['object'])->$m([
                    'user_id' => $comment_info['user_id'],
                    'object_id' => $comment_info['object_id'],
          Severity: Major
          Found in plugins/comments/modules/yf_comments.class.php and 3 other locations - About 45 mins to fix
          plugins/comments/modules/yf_comments.class.php on lines 128..136
          plugins/comments/modules/yf_comments.class.php on lines 137..145
          plugins/comments/modules/yf_comments.class.php on lines 259..267

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status