Sign upLogin

yfix/yf

View on GitHub
Star
plugins/common/classes/common/yf_image_manip.class.php

Summary

Maintainability
F
5 days
Test Coverage

Function _try_to_find_libs has a Cognitive Complexity of 78 (exceeds 5 allowed). Consider refactoring.
Open

    public function _try_to_find_libs()
    {
        if ( ! $this->AUTO_FIND_PATHS) {
            return false;
        }
Severity: Minor
Found in plugins/common/classes/common/yf_image_manip.class.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File yf_image_manip.class.php has 350 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * Crop & rotate images.
 *
Severity: Minor
Found in plugins/common/classes/common/yf_image_manip.class.php - About 4 hrs to fix

    Method _try_to_find_libs has 99 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function _try_to_find_libs()
    {
        if ( ! $this->AUTO_FIND_PATHS) {
            return false;
        }
    Severity: Major
    Found in plugins/common/classes/common/yf_image_manip.class.php - About 3 hrs to fix

      Function rotate has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          public function rotate($source_file_path, $dest_file_path, $ANGLE)
    {
        // Check source file
        if ( ! file_exists($source_file_path) || ! filesize($source_file_path) || ! is_readable($source_file_path)) {
            trigger_error('ROTATE_IMG: Source file is empty', E_USER_WARNING);
      Severity: Minor
      Found in plugins/common/classes/common/yf_image_manip.class.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _init has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _init()
    {
        // Set found paths
        if (empty($this->FOUND_NETPBM_PATH) && defined('NETPBM_PATH') && NETPBM_PATH != '') {
            $this->FOUND_NETPBM_PATH = NETPBM_PATH;
      Severity: Minor
      Found in plugins/common/classes/common/yf_image_manip.class.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function crop has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function crop($source_file_path, $dest_file_path, $LIMIT_X, $LIMIT_Y, $pos_left, $pos_top)
    {
        // Check source file
        if ( ! file_exists($source_file_path) || ! filesize($source_file_path) || ! is_readable($source_file_path)) {
            trigger_error('CROP_IMG: Source file is empty', E_USER_WARNING);
      Severity: Minor
      Found in plugins/common/classes/common/yf_image_manip.class.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method rotate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function rotate($source_file_path, $dest_file_path, $ANGLE)
    {
        // Check source file
        if ( ! file_exists($source_file_path) || ! filesize($source_file_path) || ! is_readable($source_file_path)) {
            trigger_error('ROTATE_IMG: Source file is empty', E_USER_WARNING);
      Severity: Minor
      Found in plugins/common/classes/common/yf_image_manip.class.php - About 1 hr to fix

        Method crop has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function crop($source_file_path, $dest_file_path, $LIMIT_X, $LIMIT_Y, $pos_left, $pos_top)
    {
        // Check source file
        if ( ! file_exists($source_file_path) || ! filesize($source_file_path) || ! is_readable($source_file_path)) {
            trigger_error('CROP_IMG: Source file is empty', E_USER_WARNING);
        Severity: Minor
        Found in plugins/common/classes/common/yf_image_manip.class.php - About 1 hr to fix

          Function _gd_crop has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function _gd_crop($source_path, $dest_file_path, $crop_width, $crop_height, $pos_left, $pos_top)
    {
        if ( ! extension_loaded('gd')) {
            return false;
        }
          Severity: Minor
          Found in plugins/common/classes/common/yf_image_manip.class.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method _init has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function _init()
    {
        // Set found paths
        if (empty($this->FOUND_NETPBM_PATH) && defined('NETPBM_PATH') && NETPBM_PATH != '') {
            $this->FOUND_NETPBM_PATH = NETPBM_PATH;
          Severity: Minor
          Found in plugins/common/classes/common/yf_image_manip.class.php - About 1 hr to fix

            Method _gd_crop has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function _gd_crop($source_path, $dest_file_path, $crop_width, $crop_height, $pos_left, $pos_top)
    {
        if ( ! extension_loaded('gd')) {
            return false;
        }
            Severity: Minor
            Found in plugins/common/classes/common/yf_image_manip.class.php - About 1 hr to fix

              Function _netpbm_rotate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function _netpbm_rotate($source_file_path, $dest_file_path, $LIMIT)
    {
        $PATH_TO_NETPBM = $this->FOUND_NETPBM_PATH;
        $dest_file_path = $source_file_path;
        // Check operation system
              Severity: Minor
              Found in plugins/common/classes/common/yf_image_manip.class.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _gd_rotate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function _gd_rotate($original_path, $dest_file_path, $angle)
    {
        if ( ! extension_loaded('gd')) {
            return false;
        }
              Severity: Minor
              Found in plugins/common/classes/common/yf_image_manip.class.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _netpbm_cut has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function _netpbm_cut($source_file_path, $dest_file_path, $LIMIT_Width, $LIMIT_Height, $pos_left, $pos_top)
    {
        // Generate correct resize command for NetPBM library
        $PATH_TO_NETPBM = $this->FOUND_NETPBM_PATH;
        //        $dest_file_path = $source_file_path;
              Severity: Minor
              Found in plugins/common/classes/common/yf_image_manip.class.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method _netpbm_cut has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function _netpbm_cut($source_file_path, $dest_file_path, $LIMIT_Width, $LIMIT_Height, $pos_left, $pos_top)
              Severity: Minor
              Found in plugins/common/classes/common/yf_image_manip.class.php - About 45 mins to fix

                Method _imagick_crop has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function _imagick_crop($source_file_path, $dest_file_path, $LIMIT_width, $LIMIT_height, $pos_left, $pos_top)
                Severity: Minor
                Found in plugins/common/classes/common/yf_image_manip.class.php - About 45 mins to fix

                  Method crop has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function crop($source_file_path, $dest_file_path, $LIMIT_X, $LIMIT_Y, $pos_left, $pos_top)
                  Severity: Minor
                  Found in plugins/common/classes/common/yf_image_manip.class.php - About 45 mins to fix

                    Method _gd_crop has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function _gd_crop($source_path, $dest_file_path, $crop_width, $crop_height, $pos_left, $pos_top)
                    Severity: Minor
                    Found in plugins/common/classes/common/yf_image_manip.class.php - About 45 mins to fix

                      Function crop_box has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function crop_box($source_file_path, $dest_file_path, $LIMIT_X, $LIMIT_Y)
    {
        $CROP_SIZE = $LIMIT_X;
        // Pre-check
        if ( ! file_exists($source_file_path)) {
                      Severity: Minor
                      Found in plugins/common/classes/common/yf_image_manip.class.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if ( ! empty($ext) && ($ext == 'jpg' || $ext == 'jpeg')) {
            $src_resource = imagecreatefromjpeg($original_path);
        } elseif ( ! empty($ext) && $ext == 'gif') {
            $src_resource = imagecreatefromgif($original_path);
        } elseif ( ! empty($ext) && $ext == 'png') {
                      Severity: Major
                      Found in plugins/common/classes/common/yf_image_manip.class.php and 1 other location - About 1 hr to fix
                      plugins/common/classes/common/yf_image_manip.class.php on lines 217..225

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 108.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if ( ! empty($ext) && ($ext == 'jpg' || $ext == 'jpeg')) {
            $src_resource = imagecreatefromjpeg($original_path);
        } elseif ( ! empty($ext) && $ext == 'gif') {
            $src_resource = imagecreatefromgif($original_path);
        } elseif ( ! empty($ext) && $ext == 'png') {
                      Severity: Major
                      Found in plugins/common/classes/common/yf_image_manip.class.php and 1 other location - About 1 hr to fix
                      plugins/common/classes/common/yf_image_manip.class.php on lines 257..265

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 108.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  if ( ! empty($ext) && $ext == 'gif') {
                $netpbm_cmd = $PATH_TO_NETPBM . 'giftopnm "' . $source_file_path . '" | ' . $PATH_TO_NETPBM . 'pnmcut ' . $pos_left . ' ' . $pos_top . ' ' . $LIMIT_Width . ' ' . $LIMIT_Height . ' | ' . $PATH_TO_NETPBM . 'ppmtojpeg -quality=75 > "' . $dest_file_path . '"';
            }
                      Severity: Minor
                      Found in plugins/common/classes/common/yf_image_manip.class.php and 1 other location - About 35 mins to fix
                      plugins/common/classes/common/yf_image_manip.class.php on lines 301..303

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 92.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  if ( ! empty($ext) && $ext == 'png') {
                $netpbm_cmd = $PATH_TO_NETPBM . 'pngtopnm "' . $source_file_path . '" | ' . $PATH_TO_NETPBM . 'pnmcut ' . $pos_left . ' ' . $pos_top . ' ' . $LIMIT_Width . ' ' . $LIMIT_Height . ' | ' . $PATH_TO_NETPBM . 'ppmtojpeg -quality=75 > "' . $dest_file_path . '"';
            }
                      Severity: Minor
                      Found in plugins/common/classes/common/yf_image_manip.class.php and 1 other location - About 35 mins to fix
                      plugins/common/classes/common/yf_image_manip.class.php on lines 298..300

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 92.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status