Sign upLogin

yfix/yf

View on GitHub
Star
plugins/content/classes/yf_captcha.class.php

Summary

Maintainability
D
1 day
Test Coverage

Function check has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function check($field_in_form = 'image_numbers', $input = null)
    {
        if ( ! $this->ENABLED) {
            return true;
        }
Severity: Minor
Found in plugins/content/classes/yf_captcha.class.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File yf_captcha.class.php has 254 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * Class to handle CAPTCHA images (to prevent auto-registering, flooding etc).
 *
Severity: Minor
Found in plugins/content/classes/yf_captcha.class.php - About 2 hrs to fix

    Method show_image has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function show_image($no_header = false, $no_exit = false)
    {
        if (function_exists('main')) {
            main()->NO_GRAPHICS = true;
        }
    Severity: Minor
    Found in plugins/content/classes/yf_captcha.class.php - About 2 hrs to fix

      Method check has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function check($field_in_form = 'image_numbers', $input = null)
    {
        if ( ! $this->ENABLED) {
            return true;
        }
      Severity: Minor
      Found in plugins/content/classes/yf_captcha.class.php - About 1 hr to fix

        Function show_image has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function show_image($no_header = false, $no_exit = false)
    {
        if (function_exists('main')) {
            main()->NO_GRAPHICS = true;
        }
        Severity: Minor
        Found in plugins/content/classes/yf_captcha.class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function set_symbols_array has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function set_symbols_array($input = [])
    {
        if (empty($input)) {
            return false;
        }
        Severity: Minor
        Found in plugins/content/classes/yf_captcha.class.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                for ($i = 0; $i < $this->add_rects; $i++) {
            imagefilledrectangle($image, rand(-$this->image_width, $this->image_width), rand(-$this->image_height, $this->image_height), rand(-$this->image_width, $this->image_width), rand(-$this->image_height, $this->image_height), array_rand(array_flip($this->rect_colors)));
        }
        Severity: Major
        Found in plugins/content/classes/yf_captcha.class.php and 1 other location - About 2 hrs to fix
        plugins/content/classes/yf_captcha.class.php on lines 325..327

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 125.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                for ($i = 0; $i < $this->add_lines; $i++) {
            imageline($image, rand(-$this->image_width, $this->image_width), rand(-$this->image_height, $this->image_height), rand(-$this->image_width, $this->image_width), rand(-$this->image_height, $this->image_height), array_rand(array_flip($this->line_colors)));
        }
        Severity: Major
        Found in plugins/content/classes/yf_captcha.class.php and 1 other location - About 2 hrs to fix
        plugins/content/classes/yf_captcha.class.php on lines 321..323

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 125.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status