Sign upLogin

yfix/yf

View on GitHub
Star
plugins/dashboards/classes/yf_dashboards2.class.php

Summary

Maintainability
D
2 days
Test Coverage

Function _get_grid has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    public function _get_grid($data = [])
    {
        foreach ((array) $data as $row_id => $row_items) {
            $cols = '';
            if (isset($row_items['cols']) && is_array($row_items['cols'])) {
Severity: Minor
Found in plugins/dashboards/classes/yf_dashboards2.class.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _get_grid has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function _get_grid($data = [])
    {
        foreach ((array) $data as $row_id => $row_items) {
            $cols = '';
            if (isset($row_items['cols']) && is_array($row_items['cols'])) {
Severity: Minor
Found in plugins/dashboards/classes/yf_dashboards2.class.php - About 1 hr to fix

    Method _view_widget_items has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function _view_widget_items($widgets = [])
    {
        $_orig_object = $_GET['object'];
        $_orig_action = $_GET['action'];
        $is_cloneable_item = true;
    Severity: Minor
    Found in plugins/dashboards/classes/yf_dashboards2.class.php - About 1 hr to fix

      Function _view_widget_items has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _view_widget_items($widgets = [])
    {
        $_orig_object = $_GET['object'];
        $_orig_action = $_GET['action'];
        $is_cloneable_item = true;
      Severity: Minor
      Found in plugins/dashboards/classes/yf_dashboards2.class.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function display has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function display($params = [])
    {
        $this->_time_start = microtime(true);
        if (is_string($params)) {
            $name = $params;
      Severity: Minor
      Found in plugins/dashboards/classes/yf_dashboards2.class.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function _get_dashboard_data($id = '')
    {
        if ( ! $id) {
            $id = isset($params['name']) ? $params['name'] : ($this->_name ? $this->_name : $_GET['id']);
        }
      Severity: Major
      Found in plugins/dashboards/classes/yf_dashboards2.class.php and 1 other location - About 5 hrs to fix
      plugins/common/classes/common/yf_dashboards.class.php on lines 218..235

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 195.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status