Sign upLogin

yfix/yf

View on GitHub
Star
plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php

Summary

Maintainability
F
3 days
Test Coverage

Function _collect_vars_in_file has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function _collect_vars_in_file($file, $type, $params = [])
    {
        if ( ! $file) {
            return [];
        }
Severity: Minor
Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _parse_sources has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function _parse_sources($params = [])
    {
        $files = [];
        if ($params['include_framework']) {
            $params['find_php'] && $files['framework']['php'] = $this->_scan_files('framework', 'php', $params);
Severity: Minor
Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _collect_vars_in_file has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function _collect_vars_in_file($file, $type, $params = [])
    {
        if ( ! $file) {
            return [];
        }
Severity: Minor
Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php - About 1 hr to fix

    Method _on_validate_ok has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function _on_validate_ok($params = [], $form)
    {
        $vars_db = $this->_parent->_get_all_vars_from_db();
        $found_vars = $this->_parse_sources($params);
    Severity: Minor
    Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php - About 1 hr to fix

      Function _on_validate_ok has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _on_validate_ok($params = [], $form)
    {
        $vars_db = $this->_parent->_get_all_vars_from_db();
        $found_vars = $this->_parse_sources($params);
      Severity: Minor
      Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _php_vars has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _php_vars($file, $params = [])
    {
        $code = file_get_contents($file);

        $GLOBALS['_locale_editor_collect_vars'] = [];
      Severity: Minor
      Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php - About 1 hr to fix

        Method collect has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function collect()
    {
        $defaults = [
            'back_link' => url('/@object/vars'),
            'redirect_link' => url('/@object/vars'),
        Severity: Minor
        Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php - About 1 hr to fix

          Method _parse_sources has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function _parse_sources($params = [])
    {
        $files = [];
        if ($params['include_framework']) {
            $params['find_php'] && $files['framework']['php'] = $this->_scan_files('framework', 'php', $params);
          Severity: Minor
          Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php - About 1 hr to fix

            Function _stpl_var_cleanup has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function _stpl_var_cleanup($in)
    {
        $input = stripslashes(trim($in, '"\''));
        $args = [];
        // Complex case with substitutions
            Severity: Minor
            Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return $vars;
            Severity: Major
            Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return [];
              Severity: Major
              Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (preg_match('~(?P<text>.+?)["\']{1},[\s\t]*%(?P<args>[a-z]+.+)$~ims', $in, $m)) {
            foreach (explode(';%', $m['args']) as $arg) {
                $attr_name = $attr_val = '';
                if (false !== strpos($arg, '=')) {
                    list($attr_name, $attr_val) = explode('=', trim($arg));
                Severity: Major
                Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php and 1 other location - About 6 hrs to fix
                plugins/tpl/classes/yf_tpl.class.php on lines 907..920

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 206.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ($params['include_app']) {
            $params['find_php'] && $files['app']['php'] = $this->_scan_files('app', 'php', $params);
            $params['find_stpl'] && $files['app']['stpl'] = $this->_scan_files('app', 'stpl', $params);
            $params['find_angular'] && $files['app']['ng'] = $this->_scan_files('app', 'ng', $params);
        }
                Severity: Major
                Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php and 1 other location - About 1 hr to fix
                plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php on lines 108..112

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 114.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ($params['include_framework']) {
            $params['find_php'] && $files['framework']['php'] = $this->_scan_files('framework', 'php', $params);
            $params['find_stpl'] && $files['framework']['stpl'] = $this->_scan_files('framework', 'stpl', $params);
            $params['find_angular'] && $files['framework']['ng'] = $this->_scan_files('framework', 'ng', $params);
        }
                Severity: Major
                Found in plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php and 1 other location - About 1 hr to fix
                plugins/locale/admin_modules/locale_editor/yf_locale_editor_collect.class.php on lines 113..117

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 114.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status