Sign upLogin

yfix/yf

View on GitHub
Star
plugins/notifications/admin_modules/yf_manage_notifications.class.php

Summary

Maintainability
D
2 days
Test Coverage

File yf_manage_notifications.class.php has 359 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class yf_manage_notifications
{
    public $RECEIVER_TYPES = [
Severity: Minor
Found in plugins/notifications/admin_modules/yf_manage_notifications.class.php - About 4 hrs to fix

    Method add has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function add()
    {
        $a = $_POST;
        if ((int) ($_GET['receiver_id']) != 0) {
            $a['receiver_id'] = $_GET['receiver_id'];
    Severity: Minor
    Found in plugins/notifications/admin_modules/yf_manage_notifications.class.php - About 1 hr to fix

      Method _show_filter has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _show_filter()
    {
        if (in_array($_GET['action'], ['show', ''])) {
            $filter_name = $_GET['object'];
            $r = [
      Severity: Minor
      Found in plugins/notifications/admin_modules/yf_manage_notifications.class.php - About 1 hr to fix

        Function add_receivers has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function add_receivers()
    {
        $A = $this->_get_notification($_GET['id']);
        $method_name = '_add_receivers_' . $A['receiver_type'];
        if ( ! method_exists($this, $method_name) || ! method_exists($this, $method_name . '_process')) {
        Severity: Minor
        Found in plugins/notifications/admin_modules/yf_manage_notifications.class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method view has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function view()
    {
        $A = $this->_get_notification($_GET['id']);
        $info = form($A)
            ->info('title')
        Severity: Minor
        Found in plugins/notifications/admin_modules/yf_manage_notifications.class.php - About 1 hr to fix

          Function filter_save has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function filter_save()
    {
        $A = $this->_get_notification($_POST['notification_id']);

        $filter_name = $_GET['id'] == 'manage_notifications' ? 'manage_notifications' : ($_GET['object'] . '__add_receivers__' . $A['receiver_type']);
          Severity: Minor
          Found in plugins/notifications/admin_modules/yf_manage_notifications.class.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else {
            $table = table('SELECT * FROM ' . db('notifications_receivers') . ' WHERE `notification_id`=' . (int) ($_GET['id']))
                ->text('receiver_id')
                ->text('is_read')
                ->date('add_date', ['format' => 'full', 'nowrap' => 1])
          Severity: Major
          Found in plugins/notifications/admin_modules/yf_manage_notifications.class.php and 1 other location - About 1 hr to fix
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 104..111

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 112.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  } elseif ($A['receiver_type'] == 'user_id') {
            $table = table('SELECT * FROM ' . db('notifications_receivers') . ' WHERE `notification_id`=' . (int) ($_GET['id']))
                ->text('receiver_id')
                ->text('is_read')
          Severity: Major
          Found in plugins/notifications/admin_modules/yf_manage_notifications.class.php and 1 other location - About 1 hr to fix
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 111..117

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 112.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  if ($_SESSION[$filter_name]['online'] != '') {
            $sql = 'SELECT * FROM ' . db('user') . ' WHERE `id` ' . ($_SESSION[$filter_name]['online'] != 1 ? 'NOT' : '') . ' IN (SELECT `user_id` FROM ' . db('users_online') . " WHERE `user_type`='user_id') /*FILTER*/ /*ORDER*/";
        } else {
            $sql = 'SELECT * FROM ' . db('user') . ' WHERE 1 /*FILTER*/ /*ORDER*/';
        }
          Severity: Major
          Found in plugins/notifications/admin_modules/yf_manage_notifications.class.php and 3 other locations - About 1 hr to fix
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 168..172
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 187..191
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 236..240

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  if ($_SESSION[$filter_name]['online'] != '') {
            $sql = 'SELECT `id` FROM ' . db('user') . ' WHERE `id` ' . ($_SESSION[$filter_name]['online'] != 1 ? 'NOT' : '') . ' IN (SELECT `user_id` FROM ' . db('users_online') . " WHERE `user_type`='user_id') /*FILTER*/";
        } else {
            $sql = 'SELECT `id` FROM ' . db('user') . ' WHERE 1 /*FILTER*/';
        }
          Severity: Major
          Found in plugins/notifications/admin_modules/yf_manage_notifications.class.php and 3 other locations - About 1 hr to fix
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 187..191
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 211..215
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 236..240

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  if ($_SESSION[$filter_name]['online'] != '') {
            $sql = 'SELECT `id` FROM ' . db('admin') . ' WHERE `id` ' . ($_SESSION[$filter_name]['online'] != 1 ? 'NOT' : '') . ' IN (SELECT `user_id` FROM ' . db('users_online') . " WHERE `user_type`='admin_id') /*FILTER*/ /*ORDER*/";
        } else {
            $sql = 'SELECT `id` FROM ' . db('admin') . ' WHERE 1 /*FILTER*/ /*ORDER*/';
        }
          Severity: Major
          Found in plugins/notifications/admin_modules/yf_manage_notifications.class.php and 3 other locations - About 1 hr to fix
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 168..172
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 211..215
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 236..240

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  if ($_SESSION[$filter_name]['online'] != '') {
            $sql = 'SELECT * FROM ' . db('admin') . ' WHERE `id` ' . ($_SESSION[$filter_name]['online'] != 1 ? 'NOT' : '') . ' IN (SELECT `user_id` FROM ' . db('users_online') . " WHERE `user_type`='admin_id') /*FILTER*/ /*ORDER*/";
        } else {
            $sql = 'SELECT * FROM ' . db('admin') . ' WHERE 1 /*FILTER*/ /*ORDER*/';
        }
          Severity: Major
          Found in plugins/notifications/admin_modules/yf_manage_notifications.class.php and 3 other locations - About 1 hr to fix
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 168..172
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 187..191
          plugins/notifications/admin_modules/yf_manage_notifications.class.php on lines 211..215

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status