Sign upLogin

yfix/yf

View on GitHub
Star
plugins/oauth/classes/yf_oauth.class.php

Summary

Maintainability
D
2 days
Test Coverage

Function login has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

    public function login($provider, $params = [])
    {
        if ( ! $provider) {
            return false;
        }
Severity: Minor
Found in plugins/oauth/classes/yf_oauth.class.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method login has 116 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function login($provider, $params = [])
    {
        if ( ! $provider) {
            return false;
        }
Severity: Major
Found in plugins/oauth/classes/yf_oauth.class.php - About 4 hrs to fix

    Function _load_oauth_providers has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public function _load_oauth_providers()
    {
        $config = $this->_load_oauth_config();
        if (isset($this->_providers_loaded)) {
            return $this->_providers;
    Severity: Minor
    Found in plugins/oauth/classes/yf_oauth.class.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method _load_oauth_providers has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function _load_oauth_providers()
    {
        $config = $this->_load_oauth_config();
        if (isset($this->_providers_loaded)) {
            return $this->_providers;
    Severity: Minor
    Found in plugins/oauth/classes/yf_oauth.class.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status