Sign upLogin

yfix/yf

View on GitHub
Star
plugins/payment/admin_modules/yf_manage_currency.class.php

Summary

Maintainability
D
2 days
Test Coverage

File yf_manage_currency.class.php has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class yf_manage_currency
{
    public $load_provider = [
Severity: Minor
Found in plugins/payment/admin_modules/yf_manage_currency.class.php - About 3 hrs to fix

    Method show has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function show()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
    Severity: Major
    Found in plugins/payment/admin_modules/yf_manage_currency.class.php - About 2 hrs to fix

      Method edit has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function edit()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
      Severity: Minor
      Found in plugins/payment/admin_modules/yf_manage_currency.class.php - About 1 hr to fix

        Method _filter_form_show has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _filter_form_show($filter, $replace)
    {
        $order_fields = [
            'provider_id' => 'provider_id',
            'currency_rate_id' => 'id',
        Severity: Minor
        Found in plugins/payment/admin_modules/yf_manage_currency.class.php - About 1 hr to fix

          Method update has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function update()
    {
        $url = &$this->url;
        // command line interface
        $is_cli = (php_sapi_name() == 'cli');
          Severity: Minor
          Found in plugins/payment/admin_modules/yf_manage_currency.class.php - About 1 hr to fix

            Method _update has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function _update()
    {
        $currency__api = _class('payment_api__currency');
        $result = true;
        $total = 0;
            Severity: Minor
            Found in plugins/payment/admin_modules/yf_manage_currency.class.php - About 1 hr to fix

              Method _show_filter has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function _show_filter()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
              Severity: Minor
              Found in plugins/payment/admin_modules/yf_manage_currency.class.php - About 1 hr to fix

                Function _update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function _update()
    {
        $currency__api = _class('payment_api__currency');
        $result = true;
        $total = 0;
                Severity: Minor
                Found in plugins/payment/admin_modules/yf_manage_currency.class.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                    public function _show_filter()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
                Severity: Major
                Found in plugins/payment/admin_modules/yf_manage_currency.class.php and 4 other locations - About 4 hrs to fix
                plugins/payment/admin_modules/yf_manage_deposit.class.php on lines 176..206
                plugins/payment/admin_modules/yf_manage_payment_operation.class.php on lines 142..172
                plugins/payment/admin_modules/yf_manage_payout.class.php on lines 228..258
                plugins/payment/admin_modules/yf_manage_transfer.class.php on lines 167..197

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 181.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status