Sign upLogin

yfix/yf

View on GitHub
Star
plugins/payment/admin_modules/yf_manage_payment.class.php

Summary

Maintainability
F
5 days
Test Coverage

File yf_manage_payment.class.php has 617 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class yf_manage_payment
{
    public $payment_api = null;
Severity: Major
Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 1 day to fix

    Method balance has 162 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function balance()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
    Severity: Major
    Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 6 hrs to fix

      Function _get_users_daily_payments has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _get_users_daily_payments($user_ids = [], $type = 'sum')
    {
        if ( ! $user_ids) {
            return false;
        }
      Severity: Minor
      Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _get_daily_stats has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _get_daily_stats($type = 'sum', $days = null)
    {
        $time = time();
        $days = $days ?: 60;
        $min_time = $time - $days * 86400;
      Severity: Minor
      Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method show has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function show()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
      Severity: Major
      Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 2 hrs to fix

        Method _get_users_daily_payments has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _get_users_daily_payments($user_ids = [], $type = 'sum')
    {
        if ( ! $user_ids) {
            return false;
        }
        Severity: Major
        Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 2 hrs to fix

          Method _operation_table has 51 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function _operation_table($options = null)
    {
        // import options
        is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
        // class
          Severity: Major
          Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 2 hrs to fix

            Method _get_daily_stats has 49 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function _get_daily_stats($type = 'sum', $days = null)
    {
        $time = time();
        $days = $days ?: 60;
        $min_time = $time - $days * 86400;
            Severity: Minor
            Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 1 hr to fix

              Method _show_filter has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function _show_filter()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
              Severity: Minor
              Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 1 hr to fix

                Function balance has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function balance()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
                Severity: Minor
                Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method _filter_form_balance has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function _filter_form_balance($filter, $replace)
    {
        $order_fields = [];
        foreach (explode('|', 'operation_id|datetime_update|datetime_start|datetime_finish|title|amount|balance') as $f) {
            $order_fields[$f] = $f;
                Severity: Minor
                Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 1 hr to fix

                  Method _filter_form_show has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function _filter_form_show($filter, $replace)
    {
        $order_fields = [];
        foreach (explode('|', 'user_id|name|email|add_date|last_login|num_logins|active|balance|datetime_create|datetime_update') as $f) {
            $order_fields[$f] = $f;
                  Severity: Minor
                  Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 1 hr to fix

                    Method _init has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function _init()
    {
        // class
        $this->payment_api = _class('payment_api');
        $this->manage_payment_lib = module('manage_payment_lib');
                    Severity: Minor
                    Found in plugins/payment/admin_modules/yf_manage_payment.class.php - About 1 hr to fix

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                                  table($sql, [
                'filter' => $filter,
                'filter_params' => [
                    'user_id' => ['cond' => 'in', 'field' => 'u.id'],
                    'name' => 'like',
                      Severity: Major
                      Found in plugins/payment/admin_modules/yf_manage_payment.class.php and 3 other locations - About 1 hr to fix
                      plugins/payment/admin_modules/yf_manage_deposit.class.php on lines 352..404
                      plugins/payment/admin_modules/yf_manage_payment_operation.class.php on lines 325..374
                      plugins/payment/admin_modules/yf_manage_payout.class.php on lines 419..506

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 111.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 7 locations. Consider refactoring.
                      Open

                              $result = table($_sql, [
                'filter' => $_filter,
                'filter_params' => [
                    'operation_id' => 'in',
                    'title' => 'like',
                      Severity: Major
                      Found in plugins/payment/admin_modules/yf_manage_payment.class.php and 6 other locations - About 1 hr to fix
                      plugins/payment/admin_modules/yf_manage_deposit.class.php on lines 352..413
                      plugins/payment/admin_modules/yf_manage_payment_operation.class.php on lines 325..419
                      plugins/payment/admin_modules/yf_manage_payout.class.php on lines 419..515
                      plugins/payment/admin_modules/yf_manage_payout.class.php on lines 1127..1142
                      plugins/payment/admin_modules/yf_manage_transfer.class.php on lines 281..355
                      plugins/payment/admin_modules/yf_manage_transfer.class.php on lines 619..654

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 110.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status