Sign upLogin

yfix/yf

View on GitHub
Star
plugins/payment/admin_modules/yf_manage_payment_operation.class.php

Summary

Maintainability
F
4 days
Test Coverage

Method show has 181 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function show()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
Severity: Major
Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 7 hrs to fix

    File yf_manage_payment_operation.class.php has 415 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

class yf_manage_payment_operation
{
    public $payment_api = null;
    Severity: Minor
    Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 5 hrs to fix

      Method _filter_form_show has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _filter_form_show($filter, $replace)
    {
        $order_fields = [
            'o.operation_id' => 'номер операций',
            'o.amount' => 'сумма',
      Severity: Major
      Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 2 hrs to fix

        Method _init has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _init()
    {
        // class
        $this->payment_api = _class('payment_api');
        $this->manage_payment_lib = module('manage_payment_lib');
        Severity: Minor
        Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 1 hr to fix

          Function _get_daily_data has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function _get_daily_data($days = null)
    {
        $time = time();
        $days = $days ?: 60;
        $min_time = $time - $days * 86400;
          Severity: Minor
          Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method _get_daily_data has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function _get_daily_data($days = null)
    {
        $time = time();
        $days = $days ?: 60;
        $min_time = $time - $days * 86400;
          Severity: Minor
          Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 1 hr to fix

            Method _show_filter has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function _show_filter()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
            Severity: Minor
            Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 1 hr to fix

              Avoid too many return statements within this method.
              Open

                                      return '(u.name ' . $like . ' OR u.nick ' . $like . ' OR u.login ' . $like . ' OR u.email ' . $like . ')';
              Severity: Major
              Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                    return  $result;
                Severity: Major
                Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                      return  $result;
                  Severity: Major
                  Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return  $result;
                    Severity: Major
                    Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                              return '(o.title ' . $like . ' OR o.options ' . $like . ')';
                      Severity: Major
                      Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return  $result;
                        Severity: Major
                        Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                                      return 'o.operation_id = ' . (int) $v;
                          Severity: Major
                          Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return  $result;
                            Severity: Major
                            Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return  $result;
                              Severity: Major
                              Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return
            '<div class="col-md-12">' .
                ($data_chart ? '<div class="col-md-6" title="' . t('Транзакции по дням') . '">' . $data_chart . '</div>' : '') .
                ($quick_filter ? '<div class="col-md-6 pull-right" title="' . t('Быстрый фильтр') . '">' . $quick_filter . '</div>' : '') .
            '</div>' .
                                Severity: Major
                                Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                      return  $result;
                                  Severity: Major
                                  Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                        return  $result;
                                    Severity: Major
                                    Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                      return  $result;
                                      Severity: Major
                                      Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                                    return 'o.operation_id IN(' . _es($v) . ')';
                                        Severity: Major
                                        Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                              return  $result;
                                          Severity: Major
                                          Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php - About 30 mins to fix

                                            Identical blocks of code found in 5 locations. Consider refactoring.
                                            Open

                                                public function _show_filter()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
                                            Severity: Major
                                            Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php and 4 other locations - About 4 hrs to fix
                                            plugins/payment/admin_modules/yf_manage_currency.class.php on lines 96..126
                                            plugins/payment/admin_modules/yf_manage_deposit.class.php on lines 176..206
                                            plugins/payment/admin_modules/yf_manage_payout.class.php on lines 228..258
                                            plugins/payment/admin_modules/yf_manage_transfer.class.php on lines 167..197

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 181.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Identical blocks of code found in 5 locations. Consider refactoring.
                                            Open

                                                public function _url($name, $replace = null)
    {
        $url = &$this->url;
        $result = null;
        if (empty($url[$name])) {
                                            Severity: Major
                                            Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php and 4 other locations - About 1 hr to fix
                                            plugins/payment/admin_modules/yf_manage_deposit.class.php on lines 88..100
                                            plugins/payment/admin_modules/yf_manage_payment_yandexmoney.class.php on lines 62..74
                                            plugins/payment/admin_modules/yf_manage_payout.class.php on lines 140..152
                                            plugins/payment/admin_modules/yf_manage_transfer.class.php on lines 110..122

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 112.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 7 locations. Consider refactoring.
                                            Open

                                                    $result = table($sql, [
                'filter' => $filter,
                'filter_params' => [
                    'status_id' => function ($a) use ($payment_status_in_progress_id) {
                        $result = null;
                                            Severity: Major
                                            Found in plugins/payment/admin_modules/yf_manage_payment_operation.class.php and 6 other locations - About 1 hr to fix
                                            plugins/payment/admin_modules/yf_manage_deposit.class.php on lines 352..413
                                            plugins/payment/admin_modules/yf_manage_payment.class.php on lines 332..373
                                            plugins/payment/admin_modules/yf_manage_payout.class.php on lines 419..515
                                            plugins/payment/admin_modules/yf_manage_payout.class.php on lines 1127..1142
                                            plugins/payment/admin_modules/yf_manage_transfer.class.php on lines 281..355
                                            plugins/payment/admin_modules/yf_manage_transfer.class.php on lines 619..654

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 110.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            There are no issues that match your filters.

                                            Category
                                            Status