Sign upLogin

yfix/yf

View on GitHub
Star
plugins/payment/admin_modules/yf_manage_transfer.class.php

Summary

Maintainability
F
1 wk
Test Coverage

File yf_manage_transfer.class.php has 687 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class yf_manage_transfer
{
    public $payment_api = null;
Severity: Major
Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 1 day to fix

    Method _operation has 135 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function _operation($options = null)
    {
        // import options
        is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
        // var
    Severity: Major
    Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 5 hrs to fix

      Method show has 117 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function show()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
      Severity: Major
      Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 4 hrs to fix

        Method view has 115 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function view()
    {
        // check operation
        $operation = $this->_operation();
        // import options
        Severity: Major
        Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 4 hrs to fix

          Method _init has 86 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function _init()
    {
        // class
        $this->payment_api = _class('payment_api');
        $this->manage_payment_lib = module('manage_payment_lib');
          Severity: Major
          Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 3 hrs to fix

            Function _operation has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
            Open

                public function _operation($options = null)
    {
        // import options
        is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
        // var
            Severity: Minor
            Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method _user_message has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function _user_message($options = null)
    {
        $url = &$this->url;
        // import operation
        is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
            Severity: Major
            Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 2 hrs to fix

              Method create has 46 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function create()
    {
        @$replace = [] + $_POST;
        $_this = $this;
        $result = form($replace, ['autocomplete' => 'off'])
              Severity: Minor
              Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 1 hr to fix

                Function _user_message has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function _user_message($options = null)
    {
        $url = &$this->url;
        // import operation
        is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
                Severity: Minor
                Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method _filter_form_show has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function _filter_form_show($filter, $replace)
    {
        // order
        $order_fields = [
            'o.operation_id' => 'номер операций',
                Severity: Minor
                Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 1 hr to fix

                  Method _show_filter has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function _show_filter()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
                  Severity: Minor
                  Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 1 hr to fix

                    Function view has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function view()
    {
        // check operation
        $operation = $this->_operation();
        // import options
                    Severity: Minor
                    Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this method.
                    Open

                            return  $result;
                    Severity: Major
                    Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return  $this->_user_message($result);
                      Severity: Major
                      Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return  $this->_user_message($result);
                        Severity: Major
                        Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return  $result;
                          Severity: Major
                          Found in plugins/payment/admin_modules/yf_manage_transfer.class.php - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                protected function _user_message($options = null)
    {
        $url = &$this->url;
        // import operation
        is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
                            Severity: Major
                            Found in plugins/payment/admin_modules/yf_manage_transfer.class.php and 1 other location - About 2 days to fix
                            plugins/payment/admin_modules/yf_manage_payment_yandexmoney.class.php on lines 170..230

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 511.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 5 locations. Consider refactoring.
                            Open

                                public function _show_filter()
    {
        $object = &$this->object;
        $action = &$this->action;
        $filter_name = &$this->filter_name;
                            Severity: Major
                            Found in plugins/payment/admin_modules/yf_manage_transfer.class.php and 4 other locations - About 4 hrs to fix
                            plugins/payment/admin_modules/yf_manage_currency.class.php on lines 96..126
                            plugins/payment/admin_modules/yf_manage_deposit.class.php on lines 176..206
                            plugins/payment/admin_modules/yf_manage_payment_operation.class.php on lines 142..172
                            plugins/payment/admin_modules/yf_manage_payout.class.php on lines 228..258

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 181.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    if (is_array($o_options['processing'])) {
            $processing_log = array_reverse($o_options['processing']);
            $processing = reset($processing_log);
            if (@$processing['provider_name'] && $processing['provider_name'] != $provider_name) {
                @list($processing_provider_id, $processing_provider) = $payment_api->get_provider([
                            Severity: Major
                            Found in plugins/payment/admin_modules/yf_manage_transfer.class.php and 1 other location - About 3 hrs to fix
                            plugins/payment/admin_modules/yf_manage_payout.class.php on lines 937..950

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 145.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 5 locations. Consider refactoring.
                            Open

                                public function _url($name, $replace = null)
    {
        $url = &$this->url;
        $result = null;
        if (empty($url[$name])) {
                            Severity: Major
                            Found in plugins/payment/admin_modules/yf_manage_transfer.class.php and 4 other locations - About 1 hr to fix
                            plugins/payment/admin_modules/yf_manage_deposit.class.php on lines 88..100
                            plugins/payment/admin_modules/yf_manage_payment_operation.class.php on lines 64..76
                            plugins/payment/admin_modules/yf_manage_payment_yandexmoney.class.php on lines 62..74
                            plugins/payment/admin_modules/yf_manage_payout.class.php on lines 140..152

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 112.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 7 locations. Consider refactoring.
                            Open

                                    return  table($sql, [
                'filter' => $filter,
                'filter_params' => [
                    'status_id' => function ($a) use ($payment_status_in_progress_id) {
                        $result = null;
                            Severity: Major
                            Found in plugins/payment/admin_modules/yf_manage_transfer.class.php and 6 other locations - About 1 hr to fix
                            plugins/payment/admin_modules/yf_manage_deposit.class.php on lines 352..413
                            plugins/payment/admin_modules/yf_manage_payment.class.php on lines 332..373
                            plugins/payment/admin_modules/yf_manage_payment_operation.class.php on lines 325..419
                            plugins/payment/admin_modules/yf_manage_payout.class.php on lines 419..515
                            plugins/payment/admin_modules/yf_manage_payout.class.php on lines 1127..1142
                            plugins/payment/admin_modules/yf_manage_transfer.class.php on lines 619..654

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 110.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 7 locations. Consider refactoring.
                            Open

                                        $html_operations_log = table($data, ['no_total' => true])
                ->text('operation_id', 'операция')
                ->func('options', function ($value, $extra, $row) {
                    $direction = &$row['direction'];
                    switch ($direction) {
                            Severity: Major
                            Found in plugins/payment/admin_modules/yf_manage_transfer.class.php and 6 other locations - About 1 hr to fix
                            plugins/payment/admin_modules/yf_manage_deposit.class.php on lines 352..413
                            plugins/payment/admin_modules/yf_manage_payment.class.php on lines 332..373
                            plugins/payment/admin_modules/yf_manage_payment_operation.class.php on lines 325..419
                            plugins/payment/admin_modules/yf_manage_payout.class.php on lines 419..515
                            plugins/payment/admin_modules/yf_manage_payout.class.php on lines 1127..1142
                            plugins/payment/admin_modules/yf_manage_transfer.class.php on lines 281..355

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 110.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status