Sign upLogin

yfix/yf

View on GitHub
Star
plugins/payment/classes/yf_payment_api__provider.class.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method _transaction has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _transaction($options)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
Severity: Major
Found in plugins/payment/classes/yf_payment_api__provider.class.php - About 3 hrs to fix

    Method transfer has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function transfer($options)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
    Severity: Minor
    Found in plugins/payment/classes/yf_payment_api__provider.class.php - About 1 hr to fix

      Function _transaction has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _transaction($options)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
      Severity: Minor
      Found in plugins/payment/classes/yf_payment_api__provider.class.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return  $result;
      Severity: Major
      Found in plugins/payment/classes/yf_payment_api__provider.class.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return  $_result;
        Severity: Major
        Found in plugins/payment/classes/yf_payment_api__provider.class.php - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function is_test($options = null)
    {
        $result = false;
        // import options
        is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
          Severity: Minor
          Found in plugins/payment/classes/yf_payment_api__provider.class.php and 1 other location - About 35 mins to fix
          plugins/payment/classes/yf_payment_api__provider_remote.class.php on lines 128..137

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 92.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status