Sign upLogin

yfix/yf

View on GitHub
Star
plugins/payment/classes/yf_payment_api__provider_bitcoin.class.php

Summary

Maintainability
F
3 days
Test Coverage

Function _external_response has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    public function _external_response()
    {
        $operation_id = $_GET['operation_id'];
        $secret = $_GET['secret'];
        $payment_api = $this->payment_api;
Severity: Minor
Found in plugins/payment/classes/yf_payment_api__provider_bitcoin.class.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File yf_payment_api__provider_bitcoin.class.php has 308 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

_class('payment_api__provider_remote');

class yf_payment_api__provider_bitcoin extends yf_payment_api__provider_remote
Severity: Minor
Found in plugins/payment/classes/yf_payment_api__provider_bitcoin.class.php - About 3 hrs to fix

    Method _external_response has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function _external_response()
    {
        $operation_id = $_GET['operation_id'];
        $secret = $_GET['secret'];
        $payment_api = $this->payment_api;
    Severity: Major
    Found in plugins/payment/classes/yf_payment_api__provider_bitcoin.class.php - About 3 hrs to fix

      Method _get_wallet has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _get_wallet($options)
    {
        //$_SESSION['wallet_options'] = $options;
        is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
        if (empty($_operation_id)) {
      Severity: Minor
      Found in plugins/payment/classes/yf_payment_api__provider_bitcoin.class.php - About 1 hr to fix

        Method _api_deposition has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _api_deposition($options)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
        Severity: Minor
        Found in plugins/payment/classes/yf_payment_api__provider_bitcoin.class.php - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                                  if ($real_secret == $secret) {
                            $transaction_hash = $_GET['transaction_hash'];
                            $value_in_satoshi = $_GET['value'];
                            $value_in_btc = $value_in_satoshi / 100000000;
          Severity: Major
          Found in plugins/payment/classes/yf_payment_api__provider_bitcoin.class.php - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public $method_allow = [
        'order' => [
            'payin' => [
                'blockchain',
            ],
            Severity: Major
            Found in plugins/payment/classes/yf_payment_api__provider_bitcoin.class.php and 1 other location - About 7 hrs to fix
            plugins/payment/classes/yf_payment_api__provider_bitpay.class.php on lines 36..100

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 234.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                public function payment($options)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
            Severity: Major
            Found in plugins/payment/classes/yf_payment_api__provider_bitcoin.class.php and 2 other locations - About 2 hrs to fix
            plugins/payment/classes/yf_payment_api__provider_bitpay.class.php on lines 549..570
            plugins/payment/classes/yf_payment_api__provider_remote_test.class.php on lines 117..138

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 136.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status