Sign upLogin

yfix/yf

View on GitHub
Star
plugins/payment/classes/yf_payment_api__provider_interkassa.class.php

Summary

Maintainability
F
2 wks
Test Coverage

File yf_payment_api__provider_interkassa.class.php has 1208 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

_class('payment_api__provider_remote');

class yf_payment_api__provider_interkassa extends yf_payment_api__provider_remote
Severity: Major
Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 3 days to fix

    Method api_payout has 179 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function api_payout($options = null)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
    Severity: Major
    Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 7 hrs to fix

      Function api_payout has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          public function api_payout($options = null)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
      Severity: Minor
      Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method api_request has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function api_request($options = null)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
      Severity: Major
      Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 2 hrs to fix

        Method _api_response has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _api_response()
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
        Severity: Minor
        Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 1 hr to fix

          Method _form_options has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function _form_options($options)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
          Severity: Minor
          Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 1 hr to fix

            Method _form has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function _form($data, $options = null)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
            Severity: Minor
            Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 1 hr to fix

              Function _form_options has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function _form_options($options)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
              Severity: Minor
              Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function api_request has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function api_request($options = null)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
              Severity: Minor
              Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _form has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function _form($data, $options = null)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
              Severity: Minor
              Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method api_request__checkout_b has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function api_request__checkout_b($options = null)
    {
        // get business account_id
        list($status, $account) = $this->api_request('account');
        if (empty($status)
              Severity: Minor
              Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 1 hr to fix

                Avoid too many return statements within this method.
                Open

                            return  $result;
                Severity: Major
                Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return  $result;
                  Severity: Major
                  Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return  $result;
                    Severity: Major
                    Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return  $result;
                      Severity: Major
                      Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return  $result;
                        Severity: Major
                        Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return  $object;
                          Severity: Major
                          Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return  $result;
                            Severity: Major
                            Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return  $result;
                              Severity: Major
                              Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return  $result;
                                Severity: Major
                                Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                              return  $result;
                                  Severity: Major
                                  Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                            return  $result;
                                    Severity: Major
                                    Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 30 mins to fix

                                      Function api_request__checkout_b has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          public function api_request__checkout_b($options = null)
    {
        // get business account_id
        list($status, $account) = $this->api_request('account');
        if (empty($status)
                                      Severity: Minor
                                      Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php - About 25 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  'visa_xplat_transfer_rub' => [
                'title' => 'Visa (РФ, RUB)',
                'icon' => 'visa',
                'request_option' => [
                    'paywayId' => '53983b55bf4efc80714160ca',
                                      Severity: Major
                                      Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php and 1 other location - About 2 days to fix
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 541..669

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 547.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  'mastercard_xplat_transfer_rub' => [
                'title' => 'MasterCard (РФ, RUB)',
                'icon' => 'mastercard',
                'request_option' => [
                    'paywayId' => '53983b55bf4efc80714160cb',
                                      Severity: Major
                                      Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php and 1 other location - About 2 days to fix
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 411..539

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 547.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 4 locations. Consider refactoring.
                                      Open

                                                  'visa_p2p_tasprivat_uah' => [
                'title' => 'Visa (Privat24, UAH)',
                'icon' => 'visa',
                'request_option' => [
                    // 'paywayId' => '52e7f883e4ae1a2406000000', // visa_p2p_privat_uah
                                      Severity: Major
                                      Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php and 3 other locations - About 6 hrs to fix
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 232..289
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 292..349
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 352..409

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 212.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 4 locations. Consider refactoring.
                                      Open

                                                  'mastercard_p2p_tasnotprivat_uah' => [
                'title' => 'MasterCard (UAH)',
                'icon' => 'mastercard',
                'request_option' => [
                    // 'paywayId' => '52efa871e4ae1a3008000002', // mastercard_p2p_notprivat_uah
                                      Severity: Major
                                      Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php and 3 other locations - About 6 hrs to fix
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 172..229
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 232..289
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 292..349

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 212.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 4 locations. Consider refactoring.
                                      Open

                                                  'mastercard_p2p_tasprivat_uah' => [
                'title' => 'MasterCard (Privat24, UAH)',
                'icon' => 'mastercard',
                'request_option' => [
                    // 'paywayId' => '52efa902e4ae1a780e000001', // mastercard_p2p_privat_uah
                                      Severity: Major
                                      Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php and 3 other locations - About 6 hrs to fix
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 172..229
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 232..289
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 352..409

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 212.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 4 locations. Consider refactoring.
                                      Open

                                                  'visa_p2p_tasnotprivat_uah' => [
                'title' => 'Visa (UAH)',
                'icon' => 'visa',
                'request_option' => [
                    // 'paywayId' => '52ef9b77e4ae1a3008000000', // visa_p2p_notprivat_uah
                                      Severity: Major
                                      Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php and 3 other locations - About 6 hrs to fix
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 172..229
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 292..349
                                      plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 352..409

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 212.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Identical blocks of code found in 5 locations. Consider refactoring.
                                      Open

                                          public function _url($options, $is_server = false)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
                                      Severity: Major
                                      Found in plugins/payment/classes/yf_payment_api__provider_interkassa.class.php and 4 other locations - About 2 hrs to fix
                                      plugins/payment/classes/yf_payment_api__provider_ecommpay.class.php on lines 712..725
                                      plugins/payment/classes/yf_payment_api__provider_perfectmoney.class.php on lines 304..317
                                      plugins/payment/classes/yf_payment_api__provider_webmoney.class.php on lines 734..747
                                      plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php on lines 372..385

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 121.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status