Sign upLogin

yfix/yf

View on GitHub
Star
plugins/payment/classes/yf_payment_api__provider_privat24.class.php

Summary

Maintainability
F
3 days
Test Coverage

File yf_payment_api__provider_privat24.class.php has 451 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

_class('payment_api__provider_remote');

class yf_payment_api__provider_privat24 extends yf_payment_api__provider_remote
Severity: Minor
Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 6 hrs to fix

    Method api_payout has 148 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function api_payout($method, $options)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
    Severity: Major
    Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 5 hrs to fix

      Function api_payout has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

          public function api_payout($method, $options)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
      Severity: Minor
      Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _api_response has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _api_response()
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
      Severity: Minor
      Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 1 hr to fix

        Method _form has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _form($data, $options = null)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
        Severity: Minor
        Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 1 hr to fix

          Function _form has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function _form($data, $options = null)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
          Severity: Minor
          Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _form_options has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function _form_options($options)
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
          Severity: Minor
          Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return  $result;
          Severity: Major
          Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return  $result;
            Severity: Major
            Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return  $result;
              Severity: Major
              Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return  $result;
                Severity: Major
                Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return  $result;
                  Severity: Major
                  Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return  [$status, $status_message];
                    Severity: Major
                    Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return  $result;
                      Severity: Major
                      Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return  $result;
                        Severity: Major
                        Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return  $result;
                          Severity: Major
                          Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 30 mins to fix

                            Function _api_response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function _api_response()
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
                            Severity: Minor
                            Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                public function _init()
    {
        if ( ! $this->ENABLE) {
            return  null;
        }
                            Severity: Major
                            Found in plugins/payment/classes/yf_payment_api__provider_privat24.class.php and 2 other locations - About 1 hr to fix
                            plugins/payment/classes/yf_payment_api__provider_liqpay.class.php on lines 65..78
                            plugins/payment/classes/yf_payment_api__provider_perfectmoney.class.php on lines 194..207

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 106.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status