File yf_payment_api__provider_remote.class.php has 1120 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
if ( ! function_exists('array_replace_recursive')) {
trigger_error('Not exists function "array_replace_recursive ( PHP 5 >= 5.3.0 )"', E_USER_ERROR);
}Method _api_transaction has 303 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function _api_transaction($options)
{
if ( ! $this->ENABLE) {
return null;
}Function _api_transaction has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring. Open
public function _api_transaction($options)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method payment has 134 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function payment($options)
{
if ( ! $this->ENABLE) {
return null;
}yf_payment_api__provider_remote has 33 functions (exceeds 20 allowed). Consider refactoring. Open
class yf_payment_api__provider_remote
{
public $ENABLE = null;
public $TEST_MODE = null;
Method deposition has 80 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function deposition($options)
{
if ( ! $this->ENABLE) {
return null;
}Method _update_status has 64 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function _update_status($options = null)
{
if ( ! $this->ENABLE) {
return null;
}Method validate has 61 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function validate($options)
{
// import options
is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
// check payment method, typeFunction validate has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
public function validate($options)
{
// import options
is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
// check payment method, type- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function api_url has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
public function api_url($options = null, $request_options = null)
{
// import options
is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
if ( ! empty($_url)) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method currency_conversion_payout has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function currency_conversion_payout($options)
{
// import options
is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
// varMethod amount_limit has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function amount_limit($options = null)
{
// import options
is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
if ( ! empty($_method['amount'])) {Method _amount_payout has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function _amount_payout($amount, $currency_id, $method, $is_request = true)
{
if ( ! $this->ENABLE) {
return null;
}Method api_url has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function api_url($options = null, $request_options = null)
{
// import options
is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
if ( ! empty($_url)) {Function _amount_payout has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function _amount_payout($amount, $currency_id, $method, $is_request = true)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _update_status has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function _update_status($options = null)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function payment has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function payment($options)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function currency_conversion_payout has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function currency_conversion_payout($options)
{
// import options
is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
// var- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function amount_limit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function amount_limit($options = null)
{
// import options
is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');
if ( ! empty($_method['amount'])) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return $this->result_fail(t('Неверно заполненные поля для вывода средств, проверьте и повторите запрос.'), $validation_error);Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $this->result_success();Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $object;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $object;Avoid too many return statements within this method. Open
return $object;Avoid too many return statements within this method. Open
return $this->result_success();Avoid too many return statements within this method. Open
return $object;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $object;Function get_currency_payout has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function get_currency_payout($options)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Identical blocks of code found in 2 locations. Consider refactoring. Open
public function is_test($options = null)
{
$result = false;
// import options
is_array($options) && extract($options, EXTR_PREFIX_ALL | EXTR_REFS, '');- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 92.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76