File yf_payment_api__provider_webmoney.class.php has 1210 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
_class('payment_api__provider_remote');
class yf_payment_api__provider_webmoney extends yf_payment_api__provider_remoteMethod api_payout has 144 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function api_payout($options = null)
{
if ( ! $this->ENABLE) {
return null;
}yf_payment_api__provider_webmoney has 32 functions (exceeds 20 allowed). Consider refactoring. Open
class yf_payment_api__provider_webmoney extends yf_payment_api__provider_remote
{
// номер перевода в системе учета отправителя; любое целое число без знака (целое число > 0; максимально 2^31 - 1), должно быть уникальным в пределах WMID, который подписывает запрос.
// Два перевода с одним и тем же tranid с одного WMID (даже с разных кошельков) осуществить невозможно.
// Уникальность значения tranid контролируется в интервале не менее одного года.Method _api_response has 69 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function _api_response($request)
{
if ( ! $this->ENABLE) {
return null;
}Method _form_options has 61 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function _form_options($options)
{
if ( ! $this->ENABLE) {
return null;
}Function _form_options has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
public function _form_options($options)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __api_response__result has 55 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __api_response__result($operation_id, $response)
{
if ( ! $this->ENABLE) {
return null;
}Function api_payout has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
public function api_payout($options = null)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __api_response__check has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __api_response__check($operation_id, $response)
{
if ( ! $this->ENABLE) {
return null;
}Function _api_response has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
public function _api_response($request)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method _purse_by_currency has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function _purse_by_currency($options = null)
{
if ( ! $this->ENABLE) {
return null;
}Method _payout_status_handler has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function _payout_status_handler($xml)
{
if ( ! $this->ENABLE) {
return null;
}Method __api_response__success has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __api_response__success($operation_id, $response)
{
if ( ! $this->ENABLE) {
return null;
}Method api_request has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function api_request($options = null)
{
if ( ! $this->ENABLE) {
return null;
}Method _form has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function _form($data, $options = null)
{
if ( ! $this->ENABLE) {
return null;
}Method api_request_send has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function api_request_send($options = null)
{
if ( ! $this->ENABLE) {
return null;
}Method api_request__X2 has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function api_request__X2($options = null)
{
if ( ! $this->ENABLE) {
return null;
}Function _form has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function _form($data, $options = null)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function __api_response__check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function __api_response__check($operation_id, $response)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function api_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function api_request($options = null)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _purse_by_currency has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function _purse_by_currency($options = null)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _payout_status_handler has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function _payout_status_handler($xml)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return true;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $object;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return true;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Avoid too many return statements within this method. Open
return $result;Function _xml_add has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function _xml_add(&$xml, $items)
{
if ( ! (@$xml instanceof SimpleXMLElement) || ! @$items) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function api_request__X_fields has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function api_request__X_fields(&$data, &$fields, $options)
{
foreach ($fields as $field) {
if (isset($options[$field])) {
$data[$field] = $options[$field];- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _init has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function _init()
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function api_request_send has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function api_request_send($options = null)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
public $_payout_status_message = [
'success' => 'Платеж проведен.',
// in_progress
'unknown' => 'Отсутствуют статус ответ',
'-100' => 'общая ошибка при разборе команды. неверный формат команды.',- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 242.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public $_payout_status = [
'0' => 'success',
// in_progress
'unknown' => 'in_progress',
'-100' => 'in_progress',- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 242.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 5 locations. Consider refactoring. Open
public function _url($options, $is_server = false)
{
if ( ! $this->ENABLE) {
return null;
}- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 121.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76