plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php

Summary

Maintainability
F
1 wk
Test Coverage

File yf_payment_api__provider_yandexmoney.class.php has 1026 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

_class('payment_api__provider_remote');

class yf_payment_api__provider_yandexmoney extends yf_payment_api__provider_remote
Severity: Major
Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 2 days to fix

    Method api_payout has 163 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function api_payout($options = null)
        {
            if ( ! $this->ENABLE) {
                return  null;
            }

      Method _api_response has 88 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _api_response()
          {
              if ( ! $this->ENABLE) {
                  return  null;
              }

        Function api_payout has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function api_payout($options = null)
            {
                if ( ! $this->ENABLE) {
                    return  null;
                }

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _api_authorize has 64 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _api_authorize()
            {
                if ( ! $this->ENABLE) {
                    return  null;
                }

          Method authorize_request has 64 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function authorize_request($options = null)
              {
                  if ( ! $this->ENABLE) {
                      return  null;
                  }

            Method _payout_status_handler has 57 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function _payout_status_handler($options = null)
                {
                    if ( ! $this->ENABLE) {
                        return  null;
                    }

              Method _payout_process has 55 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function _payout_process($options = null)
                  {
                      if ( ! $this->ENABLE) {
                          return  null;
                      }

                Method api_request has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function api_request($options = null)
                    {
                        if ( ! $this->ENABLE) {
                            return  null;
                        }

                  Method _form_options has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function _form_options($options)
                      {
                          if ( ! $this->ENABLE) {
                              return  null;
                          }

                    Method api_token_revoke has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function api_token_revoke($options = null)
                        {
                            if ( ! $this->ENABLE) {
                                return  null;
                            }

                      Function _form_options has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function _form_options($options)
                          {
                              if ( ! $this->ENABLE) {
                                  return  null;
                              }

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function _payout_status_handler has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function _payout_status_handler($options = null)
                          {
                              if ( ! $this->ENABLE) {
                                  return  null;
                              }

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function api_request has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function api_request($options = null)
                          {
                              if ( ! $this->ENABLE) {
                                  return  null;
                              }

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method _form has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function _form($data, $options = null)
                          {
                              if ( ! $this->ENABLE) {
                                  return  null;
                              }

                        Function _payout_process has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function _payout_process($options = null)
                            {
                                if ( ! $this->ENABLE) {
                                    return  null;
                                }

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function _api_response has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function _api_response()
                            {
                                if ( ! $this->ENABLE) {
                                    return  null;
                                }

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function _form has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function _form($data, $options = null)
                            {
                                if ( ! $this->ENABLE) {
                                    return  null;
                                }
                        Severity: Minor
                        Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 55 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function _api_authorize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function _api_authorize()
                            {
                                if ( ! $this->ENABLE) {
                                    return  null;
                                }
                        Severity: Minor
                        Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 55 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function api_token_revoke has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function api_token_revoke($options = null)
                            {
                                if ( ! $this->ENABLE) {
                                    return  null;
                                }
                        Severity: Minor
                        Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 55 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function authorize_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function authorize_request($options = null)
                            {
                                if ( ! $this->ENABLE) {
                                    return  null;
                                }
                        Severity: Minor
                        Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid too many return statements within this method.
                        Open

                                return  $result;
                        Severity: Major
                        Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return  $result;
                          Severity: Major
                          Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return  $object;
                            Severity: Major
                            Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return  $result;
                              Severity: Major
                              Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                            return  $result;
                                Severity: Major
                                Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                          return  $result;
                                  Severity: Major
                                  Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                return  $result;
                                    Severity: Major
                                    Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                      return  $result;
                                      Severity: Major
                                      Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                    return  $result;
                                        Severity: Major
                                        Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                  return  $result;
                                          Severity: Major
                                          Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                            Avoid too many return statements within this method.
                                            Open

                                                            return  $result;
                                            Severity: Major
                                            Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                              Avoid too many return statements within this method.
                                              Open

                                                          return  $result;
                                              Severity: Major
                                              Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                                Avoid too many return statements within this method.
                                                Open

                                                            return  $result;
                                                Severity: Major
                                                Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                                  Avoid too many return statements within this method.
                                                  Open

                                                                  return  $result;
                                                  Severity: Major
                                                  Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                                    Avoid too many return statements within this method.
                                                    Open

                                                            return  $result;
                                                    Severity: Major
                                                    Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                                      Avoid too many return statements within this method.
                                                      Open

                                                                  return  [null, $result];
                                                      Severity: Major
                                                      Found in plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php - About 30 mins to fix

                                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                                        Open

                                                            public function _form($data, $options = null)
                                                            {
                                                                if ( ! $this->ENABLE) {
                                                                    return  null;
                                                                }
                                                        plugins/payment/classes/yf_payment_api__provider_perfectmoney.class.php on lines 319..354

                                                        Duplicated Code

                                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                        Tuning

                                                        This issue has a mass of 281.

                                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                        Refactorings

                                                        Further Reading

                                                        Identical blocks of code found in 5 locations. Consider refactoring.
                                                        Open

                                                            public function _url($options, $is_server = false)
                                                            {
                                                                if ( ! $this->ENABLE) {
                                                                    return  null;
                                                                }
                                                        plugins/payment/classes/yf_payment_api__provider_ecommpay.class.php on lines 712..725
                                                        plugins/payment/classes/yf_payment_api__provider_interkassa.class.php on lines 931..944
                                                        plugins/payment/classes/yf_payment_api__provider_perfectmoney.class.php on lines 304..317
                                                        plugins/payment/classes/yf_payment_api__provider_webmoney.class.php on lines 734..747

                                                        Duplicated Code

                                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                        Tuning

                                                        This issue has a mass of 121.

                                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                        Refactorings

                                                        Further Reading

                                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                                        Open

                                                            public $_payout_status = [
                                                                'success' => 'success',
                                                                'in_progress' => 'in_progress',
                                                                // refused
                                                                'payment_refused' => 'refused',
                                                        plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php on lines 219..242

                                                        Duplicated Code

                                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                        Tuning

                                                        This issue has a mass of 107.

                                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                        Refactorings

                                                        Further Reading

                                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                                        Open

                                                            public $_payout_status_message = [
                                                                'success' => 'Платеж проведен.',
                                                                'in_progress' => 'Авторизация платежа не завершена. Повторите запрос спустя некоторое время.',
                                                                // refused
                                                                'payment_refused' => 'Магазин отказал в приеме платежа.',
                                                        plugins/payment/classes/yf_payment_api__provider_yandexmoney.class.php on lines 194..217

                                                        Duplicated Code

                                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                        Tuning

                                                        This issue has a mass of 107.

                                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                        Refactorings

                                                        Further Reading

                                                        There are no issues that match your filters.

                                                        Category
                                                        Status