Sign upLogin

yfix/yf

View on GitHub
Star
plugins/payment/modules/yf_payment.class.php

Summary

Maintainability
F
3 days
Test Coverage

File yf_payment.class.php has 394 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class yf_payment
{
    public $URL_REDIRECT = '/payment';
Severity: Minor
Found in plugins/payment/modules/yf_payment.class.php - About 5 hrs to fix

    Method _api_provider has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function _api_provider($request, $options)
    {
        $api = _class('api');
        $payment_api = _class('payment_api');
        $provider_name = $_GET['name'];
    Severity: Minor
    Found in plugins/payment/modules/yf_payment.class.php - About 1 hr to fix

      Method _operation_form has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function _operation_form()
    {
        // import options
        is_array($_GET) && extract($_GET, EXTR_PREFIX_ALL | EXTR_REFS, '');
        is_array($_POST) && extract($_POST, EXTR_PREFIX_ALL | EXTR_REFS, '_');
      Severity: Minor
      Found in plugins/payment/modules/yf_payment.class.php - About 1 hr to fix

        Function _api_provider has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function _api_provider($request, $options)
    {
        $api = _class('api');
        $payment_api = _class('payment_api');
        $provider_name = $_GET['name'];
        Severity: Minor
        Found in plugins/payment/modules/yf_payment.class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function t has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function t(&$strs, $set = null, $level = 0)
    {
        if ($level > 1 || ! is_array($strs)) {
            return;
        }
        Severity: Minor
        Found in plugins/payment/modules/yf_payment.class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _operation has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _operation($request, $options)
    {
        $api = _class('api');
        $payment_api = _class('payment_api');
        // update account, operation
        Severity: Minor
        Found in plugins/payment/modules/yf_payment.class.php - About 1 hr to fix

          Method _payout has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function _payout($request, $options)
    {
        $api = _class('api');
        $payment_api = _class('payment_api');
        // todo
          Severity: Minor
          Found in plugins/payment/modules/yf_payment.class.php - About 1 hr to fix

            Method _api_balance has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function _api_balance($request, $options)
    {
        // security
        $_request = [];
        foreach (['operation_id', 'amount', 'currency_id', 'provider_id', 'page', 'method_id', 'account', 'name'] as $key) {
            Severity: Minor
            Found in plugins/payment/modules/yf_payment.class.php - About 1 hr to fix

              Function _api_balance has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function _api_balance($request, $options)
    {
        // security
        $_request = [];
        foreach (['operation_id', 'amount', 'currency_id', 'provider_id', 'page', 'method_id', 'account', 'name'] as $key) {
              Severity: Minor
              Found in plugins/payment/modules/yf_payment.class.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method _balance_recharge has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function _balance_recharge($request, $options)
    {
        $api = _class('api');
        $payment_api = _class('payment_api');
        $balance = $payment_api->deposition_user($request);
              Severity: Minor
              Found in plugins/payment/modules/yf_payment.class.php - About 1 hr to fix

                Method _cancel has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function _cancel($request, $options)
    {
        $api = _class('api');
        $payment_api = _class('payment_api');
        $object = $payment_api->cancel_user($request);
                Severity: Minor
                Found in plugins/payment/modules/yf_payment.class.php - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function _cancel($request, $options)
    {
        $api = _class('api');
        $payment_api = _class('payment_api');
        $object = $payment_api->cancel_user($request);
                  Severity: Major
                  Found in plugins/payment/modules/yf_payment.class.php and 1 other location - About 5 hrs to fix
                  plugins/payment/modules/yf_payment.class.php on lines 102..132

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 202.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function _balance_recharge($request, $options)
    {
        $api = _class('api');
        $payment_api = _class('payment_api');
        $balance = $payment_api->deposition_user($request);
                  Severity: Major
                  Found in plugins/payment/modules/yf_payment.class.php and 1 other location - About 5 hrs to fix
                  plugins/payment/modules/yf_payment.class.php on lines 219..249

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 202.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status