Sign upLogin

yfix/yf

View on GitHub
Star
plugins/rewrite/classes/yf_rewrite.class.php

Summary

Maintainability
F
1 wk
Test Coverage

Function _url has a Cognitive Complexity of 135 (exceeds 5 allowed). Consider refactoring.
Open

    public function _url($params = [], $host = '', $url_str = '', $for_section = null)
    {
        if (DEBUG_MODE && ! $this->FORCE_NO_DEBUG) {
            $time_start = microtime(true);
        }
Severity: Minor
Found in plugins/rewrite/classes/yf_rewrite.class.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _url has 182 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function _url($params = [], $host = '', $url_str = '', $for_section = null)
    {
        if (DEBUG_MODE && ! $this->FORCE_NO_DEBUG) {
            $time_start = microtime(true);
        }
Severity: Major
Found in plugins/rewrite/classes/yf_rewrite.class.php - About 7 hrs to fix

    File yf_rewrite.class.php has 444 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

class yf_rewrite
{
    public $DEFAULT_HOST = '';
    Severity: Minor
    Found in plugins/rewrite/classes/yf_rewrite.class.php - About 6 hrs to fix

      Function _rewrite_replace_links has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _rewrite_replace_links($body = '', $standalone = false, $force_rewrite = false, $for_site_id = false)
    {
        if (MAIN_TYPE_ADMIN && ! $force_rewrite) {
            return $body;
        }
      Severity: Minor
      Found in plugins/rewrite/classes/yf_rewrite.class.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _correct_protocol has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _correct_protocol($url)
    {
        if ( ! strlen($url)) {
            return false;
        }
      Severity: Minor
      Found in plugins/rewrite/classes/yf_rewrite.class.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _init has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _init()
    {
        $this->REWRITE_PATTERNS = [
            'yf' => _class('rewrite_pattern_yf', 'classes/rewrite/'),
        ];
      Severity: Minor
      Found in plugins/rewrite/classes/yf_rewrite.class.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _rewrite_replace_links has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _rewrite_replace_links($body = '', $standalone = false, $force_rewrite = false, $for_site_id = false)
    {
        if (MAIN_TYPE_ADMIN && ! $force_rewrite) {
            return $body;
        }
      Severity: Major
      Found in plugins/rewrite/classes/yf_rewrite.class.php - About 3 hrs to fix

        Method _correct_protocol has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _correct_protocol($url)
    {
        if ( ! strlen($url)) {
            return false;
        }
        Severity: Major
        Found in plugins/rewrite/classes/yf_rewrite.class.php - About 2 hrs to fix

          Method _init has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function _init()
    {
        $this->REWRITE_PATTERNS = [
            'yf' => _class('rewrite_pattern_yf', 'classes/rewrite/'),
        ];
          Severity: Minor
          Found in plugins/rewrite/classes/yf_rewrite.class.php - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                    return $body;
            Severity: Major
            Found in plugins/rewrite/classes/yf_rewrite.class.php - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          } else {
                $_host = $params['host'];
                $_port = $params['port'] ?: '80';
                $_path = $params['path'] ?: '/';
                $link = $this->_correct_protocol($http_protocol . '://' . $_host . ($_port && ! in_array($_port, ['80', '443']) ? ':' . $_port : '') . ($_path ?: '/') . $u);
              Severity: Major
              Found in plugins/rewrite/classes/yf_rewrite.class.php and 1 other location - About 1 hr to fix
              plugins/rewrite/classes/yf_rewrite.class.php on lines 397..408

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 112.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if ($params['admin_host']) {
                    $_host = $params['admin_host'];
                    $_port = $params['admin_port'] ?: '80';
                    $_path = $params['admin_path'] ?: '/admin/';
                    $link = $this->_correct_protocol($http_protocol . '://' . $_host . ($_port && ! in_array($_port, ['80', '443']) ? ':' . $_port : '') . ($_path ?: '/') . $u);
              Severity: Major
              Found in plugins/rewrite/classes/yf_rewrite.class.php and 1 other location - About 1 hr to fix
              plugins/rewrite/classes/yf_rewrite.class.php on lines 409..414

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 112.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status