Sign upLogin

yfix/yf

View on GitHub
Star
plugins/search/admin_modules/yf_manage_sphinx.class.php

Summary

Maintainability
F
2 wks
Test Coverage

Function read has a Cognitive Complexity of 95 (exceeds 5 allowed). Consider refactoring.
Open

    public function read($filename)
    {
        // split the file into lines, we'll process it line by line
        $config_file = file($filename);
Severity: Minor
Found in plugins/search/admin_modules/yf_manage_sphinx.class.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File yf_manage_sphinx.class.php has 550 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

// TODO: connect subclasses from manage_sphinx/, do refactoring from subclasses into closures

class yf_manage_sphinx
Severity: Major
Found in plugins/search/admin_modules/yf_manage_sphinx.class.php - About 1 day to fix

    Method read has 102 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function read($filename)
    {
        // split the file into lines, we'll process it line by line
        $config_file = file($filename);
    Severity: Major
    Found in plugins/search/admin_modules/yf_manage_sphinx.class.php - About 4 hrs to fix

      Function _update_config has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _update_config($name = '', $no_indexing = false, $no_write = false)
    {
        $conf_file_path = $this->CONF_PATH . 'sphinx.conf';
        if (file_exists($conf_file_path) && ! is_readable($conf_file_path)) {
            return _e('Error!. File ' . $conf_file_path . ' is not readable! Please check permissions.');
      Severity: Minor
      Found in plugins/search/admin_modules/yf_manage_sphinx.class.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _update_config has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _update_config($name = '', $no_indexing = false, $no_write = false)
    {
        $conf_file_path = $this->CONF_PATH . 'sphinx.conf';
        if (file_exists($conf_file_path) && ! is_readable($conf_file_path)) {
            return _e('Error!. File ' . $conf_file_path . ' is not readable! Please check permissions.');
      Severity: Major
      Found in plugins/search/admin_modules/yf_manage_sphinx.class.php - About 2 hrs to fix

        Function _searchd_running has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function _searchd_running()
    {
        $pid_path = $this->LOG_PATH . 'searchd.pid';

        if (file_exists($pid_path)) {
        Severity: Minor
        Found in plugins/search/admin_modules/yf_manage_sphinx.class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _index has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function _index($mode, $post_id, &$message, &$subject, $poster_id, $forum_id)
        Severity: Minor
        Found in plugins/search/admin_modules/yf_manage_sphinx.class.php - About 45 mins to fix

          Function _read_last_lines has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function _read_last_lines($file, $amount)
    {
        if ( ! is_readable($file)) {
            return _e('Error!. File ' . $file . ' is not readable! Please check permissions.');
        }
          Severity: Minor
          Found in plugins/search/admin_modules/yf_manage_sphinx.class.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _index_created has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function _index_created($allow_new_files = true)
    {
        $created = false;

        foreach ((array) $this->_get_countries() as $code) {
          Severity: Minor
          Found in plugins/search/admin_modules/yf_manage_sphinx.class.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _tidy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function _tidy($create = false, $single_index = '')
    {
        $indexes = '--all';
        if ($single_index) {
            $indexes = $single_index;
          Severity: Minor
          Found in plugins/search/admin_modules/yf_manage_sphinx.class.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          class sphinx_config
{
    public $loaded = false;
    public $sections = [];
          Severity: Major
          Found in plugins/search/admin_modules/yf_manage_sphinx.class.php and 1 other location - About 1 wk to fix
          plugins/search/admin_modules/manage_sphinx/yf_manage_sphinx_config.class.php on lines 8..242

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 1262.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          class sphinx_config_section
{
    public $name;
    public $comment;
    public $end_comment;
          Severity: Major
          Found in plugins/search/admin_modules/yf_manage_sphinx.class.php and 1 other location - About 2 days to fix
          plugins/search/admin_modules/manage_sphinx/yf_manage_sphinx_config_section.class.php on lines 7..125

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 470.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          class sphinx_config_variable
{
    public $name;
    public $value;
    public $comment;
          Severity: Major
          Found in plugins/search/admin_modules/yf_manage_sphinx.class.php and 1 other location - About 3 hrs to fix
          plugins/search/admin_modules/manage_sphinx/yf_manage_sphinx_config_variable.class.php on lines 7..57

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 148.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status