Sign upLogin

yfix/yf

View on GitHub
Star
plugins/shop/admin_modules/yf_manage_shop_revisions.class.php

Summary

Maintainability
C
1 day
Test Coverage

Method new_revision has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function new_revision($function, $ids, $db_table)
    {
        if (empty($function) || empty($ids) || empty($db_table)) {
            return false;
        }
Severity: Minor
Found in plugins/shop/admin_modules/yf_manage_shop_revisions.class.php - About 1 hr to fix

    Method details has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function details()
    {
        $sql = 'SELECT * FROM ' . db('shop_revisions') . ' WHERE id=' . (int) ($_GET['id']);
        $a = db()->get($sql);
        if (empty($a)) {
    Severity: Minor
    Found in plugins/shop/admin_modules/yf_manage_shop_revisions.class.php - About 1 hr to fix

      Method _show_filter has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _show_filter()
    {
        $filters = [
            'show' => function ($filter_name, $replace) {
                $fields = ['id', 'add_date', 'action', 'item_id', 'ip', 'user_id'];
      Severity: Minor
      Found in plugins/shop/admin_modules/yf_manage_shop_revisions.class.php - About 1 hr to fix

        Function filter_save has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function filter_save()
    {
        $_GET['id'] = preg_replace('~[^0-9a-z_]+~ims', '', $_GET['id']);
        if ($_GET['id'] && false !== strpos($_GET['id'], $_GET['object'] . '__')) {
            $filter_name = $_GET['id'];
        Severity: Minor
        Found in plugins/shop/admin_modules/yf_manage_shop_revisions.class.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function new_revision has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function new_revision($function, $ids, $db_table)
    {
        if (empty($function) || empty($ids) || empty($db_table)) {
            return false;
        }
        Severity: Minor
        Found in plugins/shop/admin_modules/yf_manage_shop_revisions.class.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function rollback_revision has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function rollback_revision()
    {
        $_GET['id'] = (int) ($_GET['id']);
        $revision_data = db()->get('SELECT * FROM ' . db('shop_revisions') . ' WHERE id=' . $_GET['id']);
        if (empty($revision_data)) {
        Severity: Minor
        Found in plugins/shop/admin_modules/yf_manage_shop_revisions.class.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                return form($a, [
                'dd_mode' => 1,
            ])
            ->link('Revisions list', './?object=manage_shop_revisions')
            ->admin_info('user_id')
        Severity: Major
        Found in plugins/shop/admin_modules/yf_manage_shop_revisions.class.php and 1 other location - About 5 hrs to fix
        plugins/shop/admin_modules/manage_shop/yf_manage_shop__product_revisions.class.php on lines 575..594

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 191.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status