Sign upLogin

yfix/yf

View on GitHub
Star
plugins/shop/modules/yf_shop.class.php

Summary

Maintainability
D
1 day
Test Coverage

yf_shop has 59 functions (exceeds 20 allowed). Consider refactoring.
Open

class yf_shop extends yf_module
{
    /* Test CC numbers:

    370000000000002 American Express Test Card
Severity: Major
Found in plugins/shop/modules/yf_shop.class.php - About 1 day to fix

    File yf_shop.class.php has 401 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * Shop module.
 */
    Severity: Minor
    Found in plugins/shop/modules/yf_shop.class.php - About 5 hrs to fix

      Method _init has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _init()
    {
        $shop = module('shop');
        $shop->_shop_cats = _class('cats')->_get_items_names('shop_cats');
        $shop->_shop_cats_all = _class('cats')->_get_items_array('shop_cats');
      Severity: Minor
      Found in plugins/shop/modules/yf_shop.class.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                return [
            ['yes_no_box', 'shop__sms_order_send', 'Send SMS to user when new order arrives'],
            ['yes_no_box', 'shop__sms_order_copy', 'Send SMS copy when new order arrives'],
            ['text',         'shop__sms_order_copy_to', 'Phone numbers to send SMS copy when new order arrives'],
            ['yes_no_box', 'shop__emails_all_send', 'Send emails'],
        Severity: Minor
        Found in plugins/shop/modules/yf_shop.class.php and 1 other location - About 40 mins to fix
        plugins/assets/admin_modules/yf_manage_assets.class.php on lines 44..52

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status