Sign upLogin

yfix/yf

View on GitHub
Star
plugins/sms/classes/yf_service_turbosms.class.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function send has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function send($phone, $text, $params = [])
    {
        if ( ! $this->_is_enabled()) {
            return false;
        }
Severity: Minor
Found in plugins/sms/classes/yf_service_turbosms.class.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method send has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function send($phone, $text, $params = [])
    {
        if ( ! $this->_is_enabled()) {
            return false;
        }
Severity: Minor
Found in plugins/sms/classes/yf_service_turbosms.class.php - About 1 hr to fix

    Function _phone_cleanup has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function _phone_cleanup($phone = '', &$error = '')
    {
        $error = false;
        $phone = preg_replace('/[^0-9]+/ims', '', strip_tags($phone));
        // TODO: implement $this->allowed_countries
    Severity: Minor
    Found in plugins/sms/classes/yf_service_turbosms.class.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status