Sign upLogin

yfix/yf

View on GitHub
Star
plugins/static_pages/admin_modules/yf_static_pages.class.php

Summary

Maintainability
F
5 days
Test Coverage

File yf_static_pages.class.php has 340 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * Static/HTML pages content editor.
 *
Severity: Minor
Found in plugins/static_pages/admin_modules/yf_static_pages.class.php - About 4 hrs to fix

    Method edit has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function edit()
    {
        $a = $this->_get_info();
        if ( ! $a) {
            return _404();
    Severity: Major
    Found in plugins/static_pages/admin_modules/yf_static_pages.class.php - About 2 hrs to fix

      Function edit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function edit()
    {
        $a = $this->_get_info();
        if ( ! $a) {
            return _404();
      Severity: Minor
      Found in plugins/static_pages/admin_modules/yf_static_pages.class.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method add has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function add()
    {
        $a = (array) $_POST + (array) $a;
        $a['back_link'] = url('/@object');
        $a['locale'] = $a['locale'] ?: conf('language');
      Severity: Minor
      Found in plugins/static_pages/admin_modules/yf_static_pages.class.php - About 1 hr to fix

        Method _get_info has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _get_info($id = null, $lang = null)
    {
        $id = isset($id) ? $id : $_GET['id'];
        $lang = isset($lang) ? $lang : $_GET['page'];
        $a = db()->from(self::table)
        Severity: Minor
        Found in plugins/static_pages/admin_modules/yf_static_pages.class.php - About 1 hr to fix

          Function _get_info has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function _get_info($id = null, $lang = null)
    {
        $id = isset($id) ? $id : $_GET['id'];
        $lang = isset($lang) ? $lang : $_GET['page'];
        $a = db()->from(self::table)
          Severity: Minor
          Found in plugins/static_pages/admin_modules/yf_static_pages.class.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return false;
          Severity: Major
          Found in plugins/static_pages/admin_modules/yf_static_pages.class.php - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public function _get_info($id = null, $lang = null)
    {
        $id = isset($id) ? $id : $_GET['id'];
        $lang = isset($lang) ? $lang : $_GET['page'];
        $a = db()->from(self::table)
            Severity: Major
            Found in plugins/static_pages/admin_modules/yf_static_pages.class.php and 1 other location - About 1 day to fix
            plugins/content/admin_modules/yf_manage_tips.class.php on lines 138..172

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 350.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                public function _get_lang_links($cur_lang = null, $cur_name = null, $link_for = 'edit')
    {
        asset('bfh-select');
        $this->lang_def_country = main()->get_data('lang_def_country');
            Severity: Major
            Found in plugins/static_pages/admin_modules/yf_static_pages.class.php and 2 other locations - About 1 day to fix
            plugins/content/admin_modules/yf_manage_tips.class.php on lines 110..132
            plugins/email/admin_modules/yf_manage_emails.class.php on lines 284..306

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 335.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function _show_header()
    {
        $pheader = t('Static pages');
        $subheader = _ucwords(str_replace('_', ' ', $_GET['action']));
        $cases = [
            Severity: Major
            Found in plugins/static_pages/admin_modules/yf_static_pages.class.php and 1 other location - About 2 hrs to fix
            plugins/shop/admin_modules/manage_shop/yf_manage_shop__show_header.class.php on lines 5..21

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 124.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (is_post()) {
            foreach ((array) $keys_to_fix as $k) {
                if (false !== strpos($_POST[$k], '{') && false !== strpos($_POST[$k], '}')) {
                    $_POST[$k] = str_replace(array_values($exec_fix), array_keys($exec_fix), $_POST[$k]);
                }
            Severity: Major
            Found in plugins/static_pages/admin_modules/yf_static_pages.class.php and 2 other locations - About 1 hr to fix
            plugins/content/admin_modules/yf_manage_faq.class.php on lines 167..173
            plugins/content/admin_modules/yf_manage_news.class.php on lines 73..79

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 110.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status