Sign upLogin

yfix/yf

View on GitHub
Star
plugins/sys/admin_modules/yf_file_manager.class.php

Summary

Maintainability
F
6 days
Test Coverage

File yf_file_manager.class.php has 521 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * File manager module.
 *
Severity: Major
Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 1 day to fix

    Function copy_item2 has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
    Open

        public function copy_item2()
    {
        if ($_POST['items_to_copy']) {
            $items = unserialize(urldecode($_POST['items_to_copy']));
            foreach ((array) $items as $k => $v) {
    Severity: Minor
    Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method show has 78 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function show()
    {
        // TODO: show preview if file is image
        // TODO: doubleclick should edit file
        // TODO: buttons near eacj table row (edit/show revisions)
    Severity: Major
    Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 3 hrs to fix

      Function _get_dir_contents has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _get_dir_contents($abs_dir_name)
    {
        $contents = [
            'dirs' => [],
            'files' => [],
      Severity: Minor
      Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method edit_item has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function edit_item()
    {
        // TODO: save file revision to db on each save
        if ( ! empty($_GET['id'])) {
            $file_name = urldecode($_GET['id']);
      Severity: Major
      Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 2 hrs to fix

        Function edit_item has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function edit_item()
    {
        // TODO: save file revision to db on each save
        if ( ! empty($_GET['id'])) {
            $file_name = urldecode($_GET['id']);
        Severity: Minor
        Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function show has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function show()
    {
        // TODO: show preview if file is image
        // TODO: doubleclick should edit file
        // TODO: buttons near eacj table row (edit/show revisions)
        Severity: Minor
        Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method copy_item2 has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function copy_item2()
    {
        if ($_POST['items_to_copy']) {
            $items = unserialize(urldecode($_POST['items_to_copy']));
            foreach ((array) $items as $k => $v) {
        Severity: Minor
        Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 1 hr to fix

          Method view_item has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function view_item()
    {
        if ( ! empty($_GET['id'])) {
            $file_name = urldecode($_GET['id']);
            $file_path = $file_name;
          Severity: Minor
          Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 1 hr to fix

            Function view_item has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function view_item()
    {
        if ( ! empty($_GET['id'])) {
            $file_name = urldecode($_GET['id']);
            $file_path = $file_name;
            Severity: Minor
            Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function email_item has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function email_item()
    {
        $dir_name = urldecode($_POST['dir_name']);

        $_old_dir_name = str_replace('\\', '/', getcwd());
            Severity: Minor
            Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function delete_item has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function delete_item()
    {
        $dir_name = urldecode($_POST['dir_name']);
        foreach ((array) $_POST as $k => $v) {
            $file_name = str_replace('\\', '/', $dir_name . '/' . $v);
            Severity: Minor
            Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method copy_item has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function copy_item()
    {
        $dir_name = urldecode($_POST['dir_name']);
        $items_to_copy = [];
        foreach ((array) $_POST as $k => $v) {
            Severity: Minor
            Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 1 hr to fix

              Method email_item has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function email_item()
    {
        $dir_name = urldecode($_POST['dir_name']);

        $_old_dir_name = str_replace('\\', '/', getcwd());
              Severity: Minor
              Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 1 hr to fix

                Method _get_dir_contents has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function _get_dir_contents($abs_dir_name)
    {
        $contents = [
            'dirs' => [],
            'files' => [],
                Severity: Minor
                Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 1 hr to fix

                  Function unzip_item has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function unzip_item()
    {
        $dir_name = urldecode($_POST['dir_name']);
        $_old_dir_name = str_replace('\\', '/', getcwd());
        foreach ((array) $_POST as $k => $name) {
                  Severity: Minor
                  Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function copy_item has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function copy_item()
    {
        $dir_name = urldecode($_POST['dir_name']);
        $items_to_copy = [];
        foreach ((array) $_POST as $k => $v) {
                  Severity: Minor
                  Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function make_zip_item has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function make_zip_item()
    {
        $dir_name = urldecode($_POST['dir_name']);
        if ( ! $_POST['new_zip_name']) {
            $_POST['new_zip_name'] = 'tmp_1234';
                  Severity: Minor
                  Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function download_item has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function download_item()
    {
        $dir_name = urldecode($_POST['dir_name']);

        $_old_dir_name = str_replace('\\', '/', getcwd());
                  Severity: Minor
                  Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function upload_file has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function upload_file()
    {
        if ($_POST['verify']) {
            if ($_POST['name']) {
                $Name = $_POST['name'];
                  Severity: Minor
                  Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function chmod_item has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function chmod_item()
    {
        $dir_name = urldecode($_POST['dir_name']);
        if ( ! $_POST['new_chmod']) {
            $_POST['new_chmod'] = '755';
                  Severity: Minor
                  Found in plugins/sys/admin_modules/yf_file_manager.class.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if ( ! empty($_GET['id'])) {
            $file_name = urldecode($_GET['id']);
            $file_path = $file_name;
            $dir_name = dirname($file_path);
        } else {
                  Severity: Major
                  Found in plugins/sys/admin_modules/yf_file_manager.class.php and 1 other location - About 4 hrs to fix
                  plugins/sys/admin_modules/yf_file_manager.class.php on lines 229..244

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 163.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if ( ! empty($_GET['id'])) {
            $file_name = urldecode($_GET['id']);
            $file_path = $file_name;
            $dir_name = dirname($file_path);
        } else {
                  Severity: Major
                  Found in plugins/sys/admin_modules/yf_file_manager.class.php and 1 other location - About 4 hrs to fix
                  plugins/sys/admin_modules/yf_file_manager.class.php on lines 176..191

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 163.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status