Sign upLogin

yfix/yf

View on GitHub
Star
plugins/sys/admin_modules/yf_manage_advertising.class.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method edit has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function edit()
    {
        $_GET['id'] = (int) ($_GET['id']);
        // Do save data
        if ( ! empty($_POST)) {
Severity: Minor
Found in plugins/sys/admin_modules/yf_manage_advertising.class.php - About 1 hr to fix

    Method save has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function save()
    {
        $_GET['id'] = (int) ($_GET['id']);
        $update = [
            'ad' => _es($_POST['ad']),
    Severity: Minor
    Found in plugins/sys/admin_modules/yf_manage_advertising.class.php - About 1 hr to fix

      Function edit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function edit()
    {
        $_GET['id'] = (int) ($_GET['id']);
        // Do save data
        if ( ! empty($_POST)) {
      Severity: Minor
      Found in plugins/sys/admin_modules/yf_manage_advertising.class.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status