Sign upLogin

yfix/yf

View on GitHub
Star
plugins/sys/classes/yf_admin_methods.class.php

Summary

Maintainability
F
1 wk
Test Coverage

File yf_admin_methods.class.php has 629 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * Common admin methods hidden by simple api.
 *
Severity: Major
Found in plugins/sys/classes/yf_admin_methods.class.php - About 1 day to fix

    Function edit has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
    Open

        public function edit($params = [])
    {
        if (is_string($params)) {
            $params = ['table' => $params];
        }
    Severity: Minor
    Found in plugins/sys/classes/yf_admin_methods.class.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

        public function add($params = [])
    {
        if (is_string($params)) {
            $params = ['table' => $params];
        }
    Severity: Minor
    Found in plugins/sys/classes/yf_admin_methods.class.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method edit has 91 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function edit($params = [])
    {
        if (is_string($params)) {
            $params = ['table' => $params];
        }
    Severity: Major
    Found in plugins/sys/classes/yf_admin_methods.class.php - About 3 hrs to fix

      Method add has 78 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function add($params = [])
    {
        if (is_string($params)) {
            $params = ['table' => $params];
        }
      Severity: Major
      Found in plugins/sys/classes/yf_admin_methods.class.php - About 3 hrs to fix

        Function filter_save has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function filter_save($params = [])
    {
        if ( ! is_array($params)) {
            $params = [];
        }
        Severity: Minor
        Found in plugins/sys/classes/yf_admin_methods.class.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function find_all_hooks has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function find_all_hooks($section = 'all')
    {
        if ( ! in_array($section, ['all', 'user', 'admin'])) {
            $section = 'all';
        }
        Severity: Minor
        Found in plugins/sys/classes/yf_admin_methods.class.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method active has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function active($params = [])
    {
        if (is_string($params)) {
            $params = [
                'table' => $params,
        Severity: Minor
        Found in plugins/sys/classes/yf_admin_methods.class.php - About 1 hr to fix

          Method _get_cke_config has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function _get_cke_config($params = [])
    {
        asset('ckeditor-plugin-save');
        asset('ckeditor-plugin-autosave');
        asset('ckeditor-plugin-html5-video');
          Severity: Minor
          Found in plugins/sys/classes/yf_admin_methods.class.php - About 1 hr to fix

            Method delete has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function delete($params = [])
    {
        if (is_string($params)) {
            $params = [
                'table' => $params,
            Severity: Minor
            Found in plugins/sys/classes/yf_admin_methods.class.php - About 1 hr to fix

              Method clone_item has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function clone_item($params = [])
    {
        if (is_string($params)) {
            $params = [
                'table' => $params,
              Severity: Minor
              Found in plugins/sys/classes/yf_admin_methods.class.php - About 1 hr to fix

                Method find_all_hooks has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function find_all_hooks($section = 'all')
    {
        if ( ! in_array($section, ['all', 'user', 'admin'])) {
            $section = 'all';
        }
                Severity: Minor
                Found in plugins/sys/classes/yf_admin_methods.class.php - About 1 hr to fix

                  Function active has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function active($params = [])
    {
        if (is_string($params)) {
            $params = [
                'table' => $params,
                  Severity: Minor
                  Found in plugins/sys/classes/yf_admin_methods.class.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function clone_item has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function clone_item($params = [])
    {
        if (is_string($params)) {
            $params = [
                'table' => $params,
                  Severity: Minor
                  Found in plugins/sys/classes/yf_admin_methods.class.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function delete has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function delete($params = [])
    {
        if (is_string($params)) {
            $params = [
                'table' => $params,
                  Severity: Minor
                  Found in plugins/sys/classes/yf_admin_methods.class.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method filter_save has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function filter_save($params = [])
    {
        if ( ! is_array($params)) {
            $params = [];
        }
                  Severity: Minor
                  Found in plugins/sys/classes/yf_admin_methods.class.php - About 1 hr to fix

                    Function _admin_link_is_allowed has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function _admin_link_is_allowed($link = '')
    {
        // Currently this works only for admin section
        if (MAIN_TYPE == 'user') {
            return false;
                    Severity: Minor
                    Found in plugins/sys/classes/yf_admin_methods.class.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method find_active_modules has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function find_active_modules($section = 'all')
    {
        if ( ! in_array($section, ['all', 'user', 'admin'])) {
            $section = 'all';
        }
                    Severity: Minor
                    Found in plugins/sys/classes/yf_admin_methods.class.php - About 1 hr to fix

                      Function find_active_modules has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function find_active_modules($section = 'all')
    {
        if ( ! in_array($section, ['all', 'user', 'admin'])) {
            $section = 'all';
        }
                      Severity: Minor
                      Found in plugins/sys/classes/yf_admin_methods.class.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function _get_cke_config has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function _get_cke_config($params = [])
    {
        asset('ckeditor-plugin-save');
        asset('ckeditor-plugin-autosave');
        asset('ckeditor-plugin-html5-video');
                      Severity: Minor
                      Found in plugins/sys/classes/yf_admin_methods.class.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid too many return statements within this method.
                      Open

                              return $replace;
                      Severity: Major
                      Found in plugins/sys/classes/yf_admin_methods.class.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return $replace;
                        Severity: Major
                        Found in plugins/sys/classes/yf_admin_methods.class.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return true;
                          Severity: Major
                          Found in plugins/sys/classes/yf_admin_methods.class.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                    return (int) _class('core_blocks')->_check_block_rights($this->CENTER_BLOCK_ID, $u['object'], $u['action']);
                            Severity: Major
                            Found in plugins/sys/classes/yf_admin_methods.class.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return true;
                              Severity: Major
                              Found in plugins/sys/classes/yf_admin_methods.class.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                return js_redirect($replace['form_action']);
                                Severity: Major
                                Found in plugins/sys/classes/yf_admin_methods.class.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                              return form($replace)->auto($table, $id, [
                'links_add' => $params['links_add'],
                'db' => $db,
            ]);
                                  Severity: Major
                                  Found in plugins/sys/classes/yf_admin_methods.class.php - About 30 mins to fix

                                    Function find_hooks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        public function find_hooks($hook_name, $section = 'all')
    {
        $hooks = [];
        foreach ((array) $this->find_all_hooks($section) as $module => $_hooks) {
            foreach ((array) $_hooks as $name => $method_name) {
                                    Severity: Minor
                                    Found in plugins/sys/classes/yf_admin_methods.class.php - About 25 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                            foreach ((array) $user_modules as $module) {
            foreach ((array) get_class_methods(module($module)) as $method) {
                if (substr($method, 0, $hooks_pl) != $hooks_prefix) {
                    continue;
                }
                                    Severity: Major
                                    Found in plugins/sys/classes/yf_admin_methods.class.php and 1 other location - About 1 hr to fix
                                    plugins/sys/classes/yf_admin_methods.class.php on lines 732..742

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 108.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                            foreach ((array) $admin_modules as $module) {
            foreach ((array) get_class_methods(module($module)) as $method) {
                if (substr($method, 0, $hooks_pl) != $hooks_prefix) {
                    continue;
                }
                                    Severity: Major
                                    Found in plugins/sys/classes/yf_admin_methods.class.php and 1 other location - About 1 hr to fix
                                    plugins/sys/classes/yf_admin_methods.class.php on lines 720..730

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 108.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    There are no issues that match your filters.

                                    Category
                                    Status