Sign upLogin

yfix/yf

View on GitHub
Star
plugins/user/modules/yf_login_form.class.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method _show_form has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function _show_form()
    {
        // Already logged in users not needed to login again
        if (main()->USER_ID) {
            return js_redirect($this->DEF_REDIRECT_URL);
Severity: Minor
Found in plugins/user/modules/yf_login_form.class.php - About 1 hr to fix

    Function oauth has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function oauth($params = [])
    {
        if ( ! isset($params['only_icons'])) {
            $params['only_icons'] = 1;
        }
    Severity: Minor
    Found in plugins/user/modules/yf_login_form.class.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method oauth has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function oauth($params = [])
    {
        if ( ! isset($params['only_icons'])) {
            $params['only_icons'] = 1;
        }
    Severity: Minor
    Found in plugins/user/modules/yf_login_form.class.php - About 1 hr to fix

      Function _show_form has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _show_form()
    {
        // Already logged in users not needed to login again
        if (main()->USER_ID) {
            return js_redirect($this->DEF_REDIRECT_URL);
      Severity: Minor
      Found in plugins/user/modules/yf_login_form.class.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status