Sign upLogin

yify-pop/yify-pop

View on GitHub
Star
app/helpers/passport/actions.js

Summary

Maintainability
C
1 day
Test Coverage

Function actions has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var actions = new (function () {
  var self = this;

  var _createInit = function (authType) {
        return function (req, resp, params) {
Severity: Major
Found in app/helpers/passport/actions.js - About 3 hrs to fix

    Function actions has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    var actions = new (function () {
  var self = this;

  var _createInit = function (authType) {
        return function (req, resp, params) {
    Severity: Minor
    Found in app/helpers/passport/actions.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function local has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      this.local = function (req, resp, params) {
    var self = this
      , username = params.username
      , password = params.password
      , query = {username: {eql: username}, activatedAt: {ne: null}};
    Severity: Minor
    Found in app/helpers/passport/actions.js - About 1 hr to fix

      Function _createCallback has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          , _createCallback = function (authType) {
        return function (req, resp, params) {
          var self = this
            , handler = function (err, profile) {
                if (!profile) {
      Severity: Minor
      Found in app/helpers/passport/actions.js - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status