Sign upLogin

yify-pop/yify-pop

View on GitHub
Star

Showing 29 of 29 total issues

Function create has 139 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.create = function(self, streamURL, hostname, params) {
  var getport = require('getport');
  var request = require('request');
  var AdmZip = require('adm-zip');
  var http = require('http');
Severity: Major
Found in app/helpers/streams.js - About 5 hrs to fix

    Function Users has 116 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var Users = function () {
  this.before(requireAuth, {
    except: ['add', 'create', 'activate']
  });
    Severity: Major
    Found in app/controllers/users.js - About 4 hrs to fix

      Function Movies has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
      Open

      var Movies = function () {
  if (geddy.config.private) {
    this.before(requireAuth);
  }
      Severity: Minor
      Found in app/controllers/movies.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function Movies has 94 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var Movies = function () {
  if (geddy.config.private) {
    this.before(requireAuth);
  }
      Severity: Major
      Found in app/controllers/movies.js - About 3 hrs to fix

        Function actions has 86 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        var actions = new (function () {
  var self = this;

  var _createInit = function (authType) {
        return function (req, resp, params) {
        Severity: Major
        Found in app/helpers/passport/actions.js - About 3 hrs to fix

          Function actions has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
          Open

          var actions = new (function () {
  var self = this;

  var _createInit = function (authType) {
        return function (req, resp, params) {
          Severity: Minor
          Found in app/helpers/passport/actions.js - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function Shows has 61 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          var Shows = function () {
  if (geddy.config.private) {
    this.before(requireAuth);
  }
          Severity: Major
          Found in app/controllers/shows.js - About 2 hrs to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            childStream.start(function(pid){
                  geddy.config.streamingProcesses.push({
                    pid: pid,
                    child: childStream,
                    torrent: decodeURIComponent(params.file),
            Severity: Major
            Found in app/helpers/streams.js and 1 other location - About 2 hrs to fix
            app/helpers/streams.js on lines 145..154

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 75.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                          childStream.start(function(pid){
                geddy.config.streamingProcesses.push({
                  pid: pid,
                  child: childStream,
                  torrent: decodeURIComponent(params.file),
            Severity: Major
            Found in app/helpers/streams.js and 1 other location - About 2 hrs to fix
            app/helpers/streams.js on lines 87..96

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 75.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            , facebook: {
    name: 'Facebook'
  , keyField: 'id'
  , parseProfile: function (profile) {
      var userData = {
            Severity: Major
            Found in app/helpers/passport/strategies.js and 1 other location - About 1 hr to fix
            app/helpers/passport/strategies.js on lines 35..45

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            , yammer: {
    name: 'Yammer'
  , keyField: 'id'
  , parseProfile: function (profile) {
      var userData = {
            Severity: Major
            Found in app/helpers/passport/strategies.js and 1 other location - About 1 hr to fix
            app/helpers/passport/strategies.js on lines 24..34

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function getParams has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            exports.getParams = function (params, baseURL) {
  var yify = {};

  // Set Defaults
  yify.search = '';
            Severity: Minor
            Found in app/helpers/yify.js - About 1 hr to fix

              Function local has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                this.local = function (req, resp, params) {
    var self = this
      , username = params.username
      , password = params.password
      , query = {username: {eql: username}, activatedAt: {ne: null}};
              Severity: Minor
              Found in app/helpers/passport/actions.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  this.down = function (next) {
    var callback = function (err, data) {
          if (err) {
            throw err;
          }
                Severity: Major
                Found in db/migrations/00000000000002_create_passports.js and 1 other location - About 1 hr to fix
                db/migrations/00000000000001_create_users.js on lines 23..33

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 63.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function _createCallback has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    , _createCallback = function (authType) {
        return function (req, resp, params) {
          var self = this
            , handler = function (err, profile) {
                if (!profile) {
                Severity: Minor
                Found in app/helpers/passport/actions.js - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    this.down = function (next) {
    var callback = function (err, data) {
          if (err) {
            throw err;
          }
                  Severity: Major
                  Found in db/migrations/00000000000001_create_users.js and 1 other location - About 1 hr to fix
                  db/migrations/00000000000002_create_passports.js on lines 20..30

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 63.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function index has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    this.index = function (req, resp, params) {
    var self = this;
    var request = require('request');
    var baseURL = "http://" + req.headers.host;
                  Severity: Minor
                  Found in app/controllers/movies.js - About 1 hr to fix

                    Function show has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      this.show = function (req, resp, params) {
    var self = this;
    var request = require('request');
    var baseURL = "http://" + req.headers.host + '/';
                    Severity: Minor
                    Found in app/controllers/shows.js - About 1 hr to fix

                      Function create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        this.create = function (req, resp, params) {
    var self = this
      , user = geddy.model.User.create(params)
      , sha;
                      Severity: Minor
                      Found in app/controllers/users.js - About 1 hr to fix

                        Function CreatePassports has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                        Open

                        var CreatePassports = function () {
  this.up = function (next) {
    var def = function (t) {
          var datatype = geddy.model.autoIncrementId ? 'int' : 'string';
          t.column('authType', 'string');
                        Severity: Minor
                        Found in db/migrations/00000000000002_create_passports.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language