yify-pop/yify-pop

View on GitHub
app/helpers/streams.js

Summary

Maintainability
C
1 day
Test Coverage

Function create has 139 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.create = function(self, streamURL, hostname, params) {
  var getport = require('getport');
  var request = require('request');
  var AdmZip = require('adm-zip');
  var http = require('http');
Severity: Major
Found in app/helpers/streams.js - About 5 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                          if (fileName.substr(i) == '.srt') { // Only unzip the srt file
                            var dir = "public/subtitles/" + yifyResponse.data.movie.title + '/';
                            zip.extractEntryTo(fileName, dir , false, true);
                            fs.renameSync(dir + fileName, dir + lang + '.srt'); // Rename to language.srt
                          }
    Severity: Major
    Found in app/helpers/streams.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      for (var subs in yifySubsResponse.subs) {
                        for (var lang in yifySubsResponse.subs[subs]) {
                          var subUrl = 'http://www.yifysubtitles.com' + _.max(yifySubsResponse.subs[subs][lang], function(s){return s.rating;}).url
                          fetchSub(subUrl, 'public/subtitles/' + lang + '.zip', lang, unzip);
                          // Build the subtitle url
      Severity: Major
      Found in app/helpers/streams.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                       if ( [tmp[0]] == "dn" ) { fileName = tmp[1]; }
        Severity: Major
        Found in app/helpers/streams.js - About 45 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          childStream.start(function(pid){
                            geddy.config.streamingProcesses.push({
                              pid: pid,
                              child: childStream,
                              torrent: decodeURIComponent(params.file),
          Severity: Major
          Found in app/helpers/streams.js and 1 other location - About 2 hrs to fix
          app/helpers/streams.js on lines 145..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                        childStream.start(function(pid){
                          geddy.config.streamingProcesses.push({
                            pid: pid,
                            child: childStream,
                            torrent: decodeURIComponent(params.file),
          Severity: Major
          Found in app/helpers/streams.js and 1 other location - About 2 hrs to fix
          app/helpers/streams.js on lines 87..96

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status