yify-pop/yify-pop

View on GitHub

Showing 23 of 29 total issues

Function create has 139 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.create = function(self, streamURL, hostname, params) {
  var getport = require('getport');
  var request = require('request');
  var AdmZip = require('adm-zip');
  var http = require('http');
Severity: Major
Found in app/helpers/streams.js - About 5 hrs to fix

    Function Users has 116 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var Users = function () {
      this.before(requireAuth, {
        except: ['add', 'create', 'activate']
      });
    
    
    Severity: Major
    Found in app/controllers/users.js - About 4 hrs to fix

      Function Movies has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
      Open

      var Movies = function () {
        if (geddy.config.private) {
          this.before(requireAuth);
        }
      
      
      Severity: Minor
      Found in app/controllers/movies.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function Movies has 94 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var Movies = function () {
        if (geddy.config.private) {
          this.before(requireAuth);
        }
      
      
      Severity: Major
      Found in app/controllers/movies.js - About 3 hrs to fix

        Function actions has 86 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        var actions = new (function () {
          var self = this;
        
          var _createInit = function (authType) {
                return function (req, resp, params) {
        Severity: Major
        Found in app/helpers/passport/actions.js - About 3 hrs to fix

          Function actions has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
          Open

          var actions = new (function () {
            var self = this;
          
            var _createInit = function (authType) {
                  return function (req, resp, params) {
          Severity: Minor
          Found in app/helpers/passport/actions.js - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function Shows has 61 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          var Shows = function () {
            if (geddy.config.private) {
              this.before(requireAuth);
            }
          
          
          Severity: Major
          Found in app/controllers/shows.js - About 2 hrs to fix

            Function getParams has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            exports.getParams = function (params, baseURL) {
              var yify = {};
            
              // Set Defaults
              yify.search = '';
            Severity: Minor
            Found in app/helpers/yify.js - About 1 hr to fix

              Function local has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                this.local = function (req, resp, params) {
                  var self = this
                    , username = params.username
                    , password = params.password
                    , query = {username: {eql: username}, activatedAt: {ne: null}};
              Severity: Minor
              Found in app/helpers/passport/actions.js - About 1 hr to fix

                Function _createCallback has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    , _createCallback = function (authType) {
                        return function (req, resp, params) {
                          var self = this
                            , handler = function (err, profile) {
                                if (!profile) {
                Severity: Minor
                Found in app/helpers/passport/actions.js - About 1 hr to fix

                  Function index has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    this.index = function (req, resp, params) {
                      var self = this;
                      var request = require('request');
                      var baseURL = "http://" + req.headers.host;
                  
                  
                  Severity: Minor
                  Found in app/controllers/movies.js - About 1 hr to fix

                    Function show has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      this.show = function (req, resp, params) {
                        var self = this;
                        var request = require('request');
                        var baseURL = "http://" + req.headers.host + '/';
                    
                    
                    Severity: Minor
                    Found in app/controllers/shows.js - About 1 hr to fix

                      Function create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        this.create = function (req, resp, params) {
                          var self = this
                            , user = geddy.model.User.create(params)
                            , sha;
                      
                      
                      Severity: Minor
                      Found in app/controllers/users.js - About 1 hr to fix

                        Function CreatePassports has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                        Open

                        var CreatePassports = function () {
                          this.up = function (next) {
                            var def = function (t) {
                                  var datatype = geddy.model.autoIncrementId ? 'int' : 'string';
                                  t.column('authType', 'string');
                        Severity: Minor
                        Found in db/migrations/00000000000002_create_passports.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function CreateUsers has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        var CreateUsers = function () {
                          this.up = function (next) {
                            var def = function (t) {
                                  t.column('username', 'string');
                                  t.column('password', 'string');
                        Severity: Minor
                        Found in db/migrations/00000000000001_create_users.js - About 1 hr to fix

                          Function lookupByPassport has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            this.lookupByPassport = function (authType, profile, callback) {
                              var typeData = strategies[authType]
                                , key = String(profile[typeData.keyField]) // Important, want to use strings, not nums
                                , passport;
                          
                          
                          Severity: Minor
                          Found in app/helpers/passport/user.js - About 1 hr to fix

                            Function CreatePassports has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            var CreatePassports = function () {
                              this.up = function (next) {
                                var def = function (t) {
                                      var datatype = geddy.model.autoIncrementId ? 'int' : 'string';
                                      t.column('authType', 'string');
                            Severity: Minor
                            Found in db/migrations/00000000000002_create_passports.js - About 1 hr to fix

                              Function getParams has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                              Open

                              exports.getParams = function (params, baseURL) {
                                var yify = {};
                              
                                // Set Defaults
                                yify.search = '';
                              Severity: Minor
                              Found in app/helpers/yify.js - About 1 hr to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function getParams has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                              Open

                              exports.getParams = function (params, baseURL) {
                                var eztv = {};
                              
                                eztv.page = 1;
                                eztv.previousDisabled = 'disabled';
                              Severity: Minor
                              Found in app/helpers/eztv.js - About 45 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Avoid deeply nested control flow statements.
                              Open

                                                    if (fileName.substr(i) == '.srt') { // Only unzip the srt file
                                                      var dir = "public/subtitles/" + yifyResponse.data.movie.title + '/';
                                                      zip.extractEntryTo(fileName, dir , false, true);
                                                      fs.renameSync(dir + fileName, dir + lang + '.srt'); // Rename to language.srt
                                                    }
                              Severity: Major
                              Found in app/helpers/streams.js - About 45 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language