yiisoft/yii2

View on GitHub
framework/base/BaseObject.php

Summary

Maintainability
A
0 mins
Test Coverage

The class BaseObject has 12 public methods. Consider refactoring BaseObject to keep number of public methods under 10.
Open

class BaseObject implements Configurable
{
    /**
     * Returns the fully qualified name of this class.
     * @return string the fully qualified name of this class.
Severity: Minor
Found in framework/base/BaseObject.php by phpmd

Since: PHPMD 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects. By default it ignores methods starting with 'get' or 'set'.

Source: http://phpmd.org/rules/codesize.txt

The method hasProperty has a boolean flag argument $checkVars, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function hasProperty($name, $checkVars = true)
Severity: Minor
Found in framework/base/BaseObject.php by phpmd

Since: PHPMD 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example:

class Foo {
      public function bar($flag = true) {
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

The method canGetProperty has a boolean flag argument $checkVars, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function canGetProperty($name, $checkVars = true)
Severity: Minor
Found in framework/base/BaseObject.php by phpmd

Since: PHPMD 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example:

class Foo {
      public function bar($flag = true) {
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

The method canSetProperty has a boolean flag argument $checkVars, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function canSetProperty($name, $checkVars = true)
Severity: Minor
Found in framework/base/BaseObject.php by phpmd

Since: PHPMD 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example:

class Foo {
      public function bar($flag = true) {
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

There are no issues that match your filters.

Category
Status