# yiisoft/yii2

framework/rbac/DbManager.php

### Summary

A
3 hrs

#### The class DbManager has 28 non-getter- and setter-methods. Consider refactoring DbManager to keep number of methods under 25. Open

class DbManager extends BaseManager
{
/**
* @var Connection|array|string the DB connection object or the application component ID of the DB connection.
* After the DbManager object is created, if you want to change this property, you should only assign it
Found in framework/rbac/DbManager.php by phpmd

## TooManyMethods

### Since: 0.1

A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

The default was changed from 10 to 25 in PHPMD 2.3.

## Example

### Source https://phpmd.org/rules/codesize.html#toomanymethods

#### The class DbManager has an overall complexity of 136 which is very high. The configured complexity threshold is 50. Open

class DbManager extends BaseManager
{
/**
* @var Connection|array|string the DB connection object or the application component ID of the DB connection.
* After the DbManager object is created, if you want to change this property, you should only assign it
Found in framework/rbac/DbManager.php by phpmd

#### The class DbManager has 16 public methods. Consider refactoring DbManager to keep number of public methods under 10. Open

class DbManager extends BaseManager
{
/**
* @var Connection|array|string the DB connection object or the application component ID of the DB connection.
* After the DbManager object is created, if you want to change this property, you should only assign it
Found in framework/rbac/DbManager.php by phpmd

## TooManyPublicMethods

### Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

## Example

### Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

#### Function loadFromCache has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open

    public function loadFromCache()
{
if ($this->items !== null || !$this->cache instanceof CacheInterface) {
return;
}
Found in framework/rbac/DbManager.php - About 1 hr to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function checkAccessFromCache has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open

    protected function checkAccessFromCache($user,$itemName, $params,$assignments)
{
if (!isset($this->items[$itemName])) {
return false;
}
Found in framework/rbac/DbManager.php - About 1 hr to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function checkAccessRecursive has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open

    protected function checkAccessRecursive($user,$itemName, $params,$assignments)
{
if (($item =$this->getItem($itemName)) === null) { return false; } Found in framework/rbac/DbManager.php - About 35 mins to fix # Cognitive Complexity Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend. ### A method's cognitive complexity is based on a few simple rules: • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one • Code is considered more complex for each "break in the linear flow of the code" • Code is considered more complex when "flow breaking structures are nested" ### Further reading #### Avoid too many return statements within this method. Open  return false; Found in framework/rbac/DbManager.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return false; Found in framework/rbac/DbManager.php - About 30 mins to fix #### The class DbManager has 1020 lines of code. Current threshold is 1000. Avoid really long classes. Open class DbManager extends BaseManager { /** * @var Connection|array|string the DB connection object or the application component ID of the DB connection. * After the DbManager object is created, if you want to change this property, you should only assign it Found in framework/rbac/DbManager.php by phpmd #### The method loadFromCache() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open  public function loadFromCache() { if ($this->items !== null || !$this->cache instanceof CacheInterface) { return; } Found in framework/rbac/DbManager.php by phpmd ## CyclomaticComplexity ### Since: 0.1 Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity. ## Example // Cyclomatic Complexity = 11 class Foo { 1 public function example() { 2 if ($a == $b) { 3 if ($a1 == $b1) { fiddle(); 4 } elseif ($a2 == $b2) { fiddle(); } else { fiddle(); } 5 } elseif ($c == $d) { 6 while ($c == $d) { fiddle(); } 7 } elseif ($e == $f) { 8 for ($n = 0; $n <$h; $n++) { fiddle(); } } else { switch ($z) {
9               case 1:
fiddle();
break;
10              case 2:
fiddle();
break;
11              case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}

### Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

#### The class DbManager has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13. Open

class DbManager extends BaseManager
{
/**
* @var Connection|array|string the DB connection object or the application component ID of the DB connection.
* After the DbManager object is created, if you want to change this property, you should only assign it
Found in framework/rbac/DbManager.php by phpmd

## CouplingBetweenObjects

### Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

## Example

class Foo {
/**
* @var \foo\bar\X
*/
private $x = null; /** * @var \foo\bar\Y */ private$y = null;

/**
* @var \foo\bar\Z
*/
private $z = null; public function setFoo(\Foo$foo) {}
public function setBar(\Bar $bar) {} public function setBaz(\Baz$baz) {}

/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {} // ... } ### Source https://phpmd.org/rules/design.html#couplingbetweenobjects #### Remove error control operator '@' on line 449. Open  protected function populateItem($row)
{
$class =$row['type'] == Item::TYPE_PERMISSION ? Permission::className() : Role::className();

if (!isset($row['data']) || ($data = @unserialize(is_resource($row['data']) ? stream_get_contents($row['data']) : $row['data'])) === false) { Found in framework/rbac/DbManager.php by phpmd ## ErrorControlOperator Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler. ## Example function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to$key
}

### Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

#### Avoid assigning values to variables in if clauses and the like (line '203', column '14'). Open

    protected function checkAccessRecursive($user,$itemName, $params,$assignments)
{
if (($item =$this->getItem($itemName)) === null) { return false; } Found in framework/rbac/DbManager.php by phpmd ## IfStatementAssignment ### Since: 2.7.0 Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like. ## Example class Foo { public function bar($flag)
{
if ($foo = 'bar') { // possible typo // ... } if ($baz = 0) { // always false
// ...
}
}
}

### Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

#### Avoid assigning values to variables in if clauses and the like (line '449', column '38'). Open

    protected function populateItem($row) {$class = $row['type'] == Item::TYPE_PERMISSION ? Permission::className() : Role::className(); if (!isset($row['data']) || ($data = @unserialize(is_resource($row['data']) ? stream_get_contents($row['data']) :$row['data'])) === false) {
Found in framework/rbac/DbManager.php by phpmd

## IfStatementAssignment

### Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

## Example

class Foo
{
public function bar($flag) { if ($foo = 'bar') { // possible typo
// ...
}
if (\$baz = 0) { // always false
// ...
}
}
}