yiisoft/yii2

View on GitHub
framework/web/CookieCollection.php

Summary

Maintainability
A
0 mins
Test Coverage

The class CookieCollection has 11 public methods. Consider refactoring CookieCollection to keep number of public methods under 10.
Open

class CookieCollection extends BaseObject implements \IteratorAggregate, \ArrayAccess, \Countable
{
    /**
     * @var bool whether this collection is read only.
     */
Severity: Minor
Found in framework/web/CookieCollection.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The method remove has a boolean flag argument $removeFromBrowser, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function remove($cookie, $removeFromBrowser = true)
Severity: Minor
Found in framework/web/CookieCollection.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid unused parameters such as '$name'.
Open

    public function offsetSet($name, $cookie)
Severity: Minor
Found in framework/web/CookieCollection.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

There are no issues that match your filters.

Category
Status