yiisoft/yii2

View on GitHub
framework/web/UrlManager.php

Summary

Maintainability
D
2 days
Test Coverage

Function createUrl has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

    public function createUrl($params)
    {
        $params = (array) $params;
        $anchor = isset($params['#']) ? '#' . $params['#'] : '';
        unset($params['#'], $params[$this->routeParam]);
Severity: Minor
Found in framework/web/UrlManager.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseRequest has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    public function parseRequest($request)
    {
        if ($this->enablePrettyUrl) {
            /* @var $rule UrlRule */
            foreach ($this->rules as $rule) {
Severity: Minor
Found in framework/web/UrlManager.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class UrlManager has an overall complexity of 85 which is very high. The configured complexity threshold is 50.
Open

class UrlManager extends Component
{
    /**
     * @var bool whether to enable pretty URLs. Instead of putting all parameters in the query
     * string part of a URL, pretty URLs allow using path info to represent some of the parameters
Severity: Minor
Found in framework/web/UrlManager.php by phpmd

Since: PHPMD 0.2.5

The Weighted Method Count (WMC) of a class is a good indicator of how much time and effort is required to modify and maintain this class. The WMC metric is defined as the sum of complexities of all methods declared in a class. A large number of methods also means that this class has a greater potential impact on derived classes.

Example:

class Foo {
      public function bar() {
          if ($a == $b)  {
              if ($a1 == $b1) {
                  fiddle();
              } elseif ($a2 == $b2) {
                  fiddle();
              } else {
              }
          }
      }
      public function baz() {
          if ($a == $b) {
              if ($a1 == $b1) {
                  fiddle();
              } elseif ($a2 == $b2) {
                  fiddle();
              } else {
              }
          }
      }
      // Several other complex methods
  }

Source: http://phpmd.org/rules/codesize.txt

Function buildRules has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    protected function buildRules($ruleDeclarations)
    {
        $builtRules = $this->getBuiltRulesFromCache($ruleDeclarations);
        if ($builtRules !== false) {
            return $builtRules;
Severity: Minor
Found in framework/web/UrlManager.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getUrlFromCache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getUrlFromCache($cacheKey, $route, $params)
    {
        if (!empty($this->_ruleCache[$cacheKey])) {
            foreach ($this->_ruleCache[$cacheKey] as $rule) {
                /* @var $rule UrlRule */
Severity: Minor
Found in framework/web/UrlManager.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                return "$baseUrl/{$url}{$anchor}";
Severity: Major
Found in framework/web/UrlManager.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return [$pathInfo, []];
    Severity: Major
    Found in framework/web/UrlManager.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return $url . $anchor;
      Severity: Major
      Found in framework/web/UrlManager.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->normalizer->normalizeRoute([$pathInfo, []]);
        Severity: Major
        Found in framework/web/UrlManager.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return "$baseUrl/{$route}{$anchor}";
          Severity: Major
          Found in framework/web/UrlManager.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return [(string) $route, []];
            Severity: Major
            Found in framework/web/UrlManager.php - About 30 mins to fix

              Function init has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function init()
                  {
                      parent::init();
              
                      if ($this->normalizer !== false) {
              Severity: Minor
              Found in framework/web/UrlManager.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              The method createUrl() has an NPath complexity of 17292. The configured NPath complexity threshold is 200.
              Open

                  public function createUrl($params)
                  {
                      $params = (array) $params;
                      $anchor = isset($params['#']) ? '#' . $params['#'] : '';
                      unset($params['#'], $params[$this->routeParam]);
              Severity: Minor
              Found in framework/web/UrlManager.php by phpmd

              Since: PHPMD 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example:

              class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              The method parseRequest() has an NPath complexity of 562. The configured NPath complexity threshold is 200.
              Open

                  public function parseRequest($request)
                  {
                      if ($this->enablePrettyUrl) {
                          /* @var $rule UrlRule */
                          foreach ($this->rules as $rule) {
              Severity: Minor
              Found in framework/web/UrlManager.php by phpmd

              Since: PHPMD 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example:

              class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              The method parseRequest() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
              Open

                  public function parseRequest($request)
                  {
                      if ($this->enablePrettyUrl) {
                          /* @var $rule UrlRule */
                          foreach ($this->rules as $rule) {
              Severity: Minor
              Found in framework/web/UrlManager.php by phpmd

              Since: PHPMD 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example:

              // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              The method createUrl() has a Cyclomatic Complexity of 24. The configured cyclomatic complexity threshold is 10.
              Open

                  public function createUrl($params)
                  {
                      $params = (array) $params;
                      $anchor = isset($params['#']) ? '#' . $params['#'] : '';
                      unset($params['#'], $params[$this->routeParam]);
              Severity: Minor
              Found in framework/web/UrlManager.php by phpmd

              Since: PHPMD 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example:

              // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              The method addRules has a boolean flag argument $append, which is a certain sign of a Single Responsibility Principle violation.
              Open

                  public function addRules($rules, $append = true)
              Severity: Minor
              Found in framework/web/UrlManager.php by phpmd

              Since: PHPMD 1.4.0

              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

              Example:

              class Foo {
                    public function bar($flag = true) {
                    }
                }

              Source: http://phpmd.org/rules/cleancode.txt

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              } elseif (strncmp($url, '//', 2) === 0) {
                                  if ($baseUrl !== '' && ($pos = strpos($url, '/', 2)) !== false) {
                                      return substr($url, 0, $pos) . $baseUrl . substr($url, $pos) . $anchor;
                                  }
              
              
              Severity: Major
              Found in framework/web/UrlManager.php and 1 other location - About 1 hr to fix
              framework/web/UrlManager.php on lines 434..446

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 87.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (strpos($url, '://') !== false) {
                                  if ($baseUrl !== '' && ($pos = strpos($url, '/', 8)) !== false) {
                                      return substr($url, 0, $pos) . $baseUrl . substr($url, $pos) . $anchor;
                                  }
              
              
              Severity: Major
              Found in framework/web/UrlManager.php and 1 other location - About 1 hr to fix
              framework/web/UrlManager.php on lines 440..446

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 87.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status