app/controllers/ads_controller.rb
Method index
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
Open
def index
@categories = AdCategory.where(parent_id: params[:category]||nil).asc(:name)
if params[:category]
@category = AdCategory.find(params[:category])
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method index
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def index
@categories = AdCategory.where(parent_id: params[:category]||nil).asc(:name)
if params[:category]
@category = AdCategory.find(params[:category])
end
Method extract_youtube_videos
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def extract_youtube_videos (html_string)
urls = URI.extract html_string
urls_converted = urls.uniq.map do |url|
if url.blank?
nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"