Sign upLogin

yippie-io/iUPB

View on GitHub
Star
app/models/event.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method recurring_end_greater_than_start_time has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def recurring_end_greater_than_start_time
      if recurring
        if recurring_end
          errors.add(:recurring_end, "can't be set before start time") if recurring_end < start_time.to_date
        else
Severity: Minor
Found in app/models/event.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _name has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def _name
    if self.course and !self.custom
      return self.course.title if self.course.course_type === "course"
      return self.course.group_title if self.course.course_type === "group"
    end
Severity: Minor
Found in app/models/event.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_recurring has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def update_recurring # untested. might be an infinite loop. TODO
    if self.recurring or self.parent_event
      (self.recurring ? self : self.parent_event).children_events.each do |e|
        e.update_attributes(name: self.name, start_time: self.start_time, end_time: self.end_time, location: self.location)
      end
Severity: Minor
Found in app/models/event.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status