Sign upLogin

yippie-io/iUPB

View on GitHub
Star
lib/restaurant_helper.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method get_menu_data has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def self.get_menu_data(csv_uri)
    old_locale = I18n.locale
    I18n.locale = :de
    
    csv = Rails.cache.fetch("iUPB.restaurant_csv", :expires_in => 2.hours) do
Severity: Minor
Found in lib/restaurant_helper.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_menu_data has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.get_menu_data(csv_uri)
    old_locale = I18n.locale
    I18n.locale = :de
    
    csv = Rails.cache.fetch("iUPB.restaurant_csv", :expires_in => 2.hours) do
Severity: Major
Found in lib/restaurant_helper.rb - About 2 hrs to fix

    Method update_database has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.update_database
    Restaurant.all.each do |restaurant|
      restaurant.menus.where(:date.lt => Date.today.to_time.midnight.utc).destroy_all
    end
    self.get_menu_data(ENV["STWPB_CSV_URL"]).each do |restaurant, menus|
    Severity: Minor
    Found in lib/restaurant_helper.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status