Sign upLogin

yjjnls/Notes

View on GitHub
Star

Showing 6 of 6 total issues

Function constructor has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    constructor(signal_bridge, room_id, endpoint_name, app, id = uuid.v4()) {

        this.signal_bridge = signal_bridge;
        this.room_id = room_id;
        this.endpoint_name = endpoint_name;
Severity: Major
Found in others/webrtc_socket.io.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        handleCandidate(data) {
        this.app.call('remote_candidate', {
            name: this.endpoint_name,
            candidate: data.candidate,
            sdpMLineIndex: data.sdpMLineIndex
    Severity: Major
    Found in others/webrtc_socket.io.js and 1 other location - About 1 hr to fix
    others/webrtc_socket.io.js on lines 99..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        handleSdp(data) {
        this.app.call('remote_sdp', {
            name: this.endpoint_name,
            type: data.type,
            sdp: data.sdp
    Severity: Major
    Found in others/webrtc_socket.io.js and 1 other location - About 1 hr to fix
    others/webrtc_socket.io.js on lines 110..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function connect has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        connect() {
        this.io = socket(`${this.signal_bridge}?userid=${this.id}&sessionid=${this.room_id}&msgEvent=${this.socketMessageEvent}&socketCustomEvent=RTCMultiConnection-Custom-Message&autoCloseEntireSession=false&maxParticipantsAllowed=1000`);

        let io = this.io;
        let self = this;
    Severity: Minor
    Found in others/webrtc_socket.io.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                              "message": {
                            "newParticipationRequest": true,
                            "isOneWay": false,
                            "isDataOnly": false,
                            "localPeerSdpConstraints": {
      Severity: Minor
      Found in others/webrtc_socket.io.js and 1 other location - About 55 mins to fix
      others/webrtc_socket.io.js on lines 19..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  "message": {
                "newParticipationRequest": true,
                "isOneWay": false,
                "isDataOnly": false,
                "localPeerSdpConstraints": {
      Severity: Minor
      Found in others/webrtc_socket.io.js and 1 other location - About 55 mins to fix
      others/webrtc_socket.io.js on lines 55..67

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language