yoctore/yocto-paypal

View on GitHub

Showing 14 of 14 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      amount            : joi.object().required().keys({
        total     : joi.number().required().min(0),
        currency  : joi.string().required().empty(),
        details   : joi.object().optional().keys({
          subtotal  : joi.number().required().min(0),
Severity: Major
Found in src/index.js and 1 other location - About 7 hrs to fix
src/index.js on lines 187..195

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 190.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    amount          : joi.object().required().keys({
      total     : joi.number().required().min(0),
      currency  : joi.string().required().empty(),
      details   : joi.object().optional().keys({
        subtotal  : joi.number().required().min(0),
Severity: Major
Found in src/index.js and 1 other location - About 7 hrs to fix
src/index.js on lines 123..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 190.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  this.paypal.authorization.void(id, function (error, payment) {
    // check if an error occured
    if (error) {
      this.logger.error('[ YoctoPaypal.cancelPayment.void ] - An error occured' +
      ' when creating the authorization payment, more details : ' + error);
Severity: Major
Found in src/index.js and 1 other location - About 4 hrs to fix
src/index.js on lines 155..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  this.paypal.payment.create(paymentData, function (error, payment) {
    // check if an error occured
    if (error) {
      this.logger.error('[ YoctoPaypal.createCreditCardAuthorization.create ] - An error occured' +
      ' when creating the authorization payment, more details : ' + error);
Severity: Major
Found in src/index.js and 1 other location - About 4 hrs to fix
src/index.js on lines 269..283

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function createCreditCardAuthorization has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

YoctoPaypal.prototype.createCreditCardAuthorization = function (paymentData) {
  // create a promise deferred
  var deferred = Q.defer();

  // Validation schema of created
Severity: Major
Found in src/index.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      if (result.error) {
        // An error occured joi schema is not conform
        this.logger.error('[ YoctoPaypal.cancelPayment.joi ] - an error occured' +
        ' schema is not conform, more details : ' + result.error.toString());
        // Config file was not loaded
    Severity: Major
    Found in src/index.js and 1 other location - About 2 hrs to fix
    src/index.js on lines 63..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      if (result.error) {
        // An error occured joi schema is not conform
        this.logger.error('[ YoctoPaypal.loadConfig.joi ] - an error occured when loading ' +
        'configuration, more details : ' + result.error.toString());
        // Config file was not loaded
    Severity: Major
    Found in src/index.js and 1 other location - About 2 hrs to fix
    src/index.js on lines 259..266

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      if (result.error) {
        // An error occured joi schema is not conform
        this.logger.error('[ YoctoPaypal.createCreditCardAuthorization.joi ] - an error occured' +
        ' schema is not conform, more details : ' + result.error.toString());
        // Config file was not loaded
    Severity: Major
    Found in src/index.js and 1 other location - About 2 hrs to fix
    src/index.js on lines 204..211

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 82.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      if (result.error) {
        // An error occured joi schema is not conform
        this.logger.error('[ YoctoPaypal.capturePayment.joi ] - an error occured' +
        ' schema is not conform, more details : ' + result.error.toString());
        // Config file was not loaded
    Severity: Major
    Found in src/index.js and 1 other location - About 2 hrs to fix
    src/index.js on lines 142..149

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 82.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function capturePayment has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    YoctoPaypal.prototype.capturePayment = function (id, paymentData) {
      // create a promise deferred
      var deferred = Q.defer();
    
      // schema of request
    Severity: Minor
    Found in src/index.js - About 1 hr to fix

      Function exports has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function (grunt) {
        // init config
        grunt.initConfig({
          // default package
          pkg       : grunt.file.readJSON('package.json'),
      Severity: Minor
      Found in Gruntfile.js - About 1 hr to fix

        Unexpected trailing comma.
        Open

                      state       : joi.string().required().empty(),
        Severity: Minor
        Found in src/index.js by eslint

        require or disallow trailing commas (comma-dangle)

        Trailing commas in object literals are valid according to the ECMAScript 5 (and ECMAScript 3!) spec. However, IE8 (when not in IE8 document mode) and below will throw an error when it encounters trailing commas in JavaScript.

        var foo = {
            bar: "baz",
            qux: "quux",
        };

        Trailing commas simplify adding and removing items to objects and arrays, since only the lines you are modifying must be touched. Another argument in favor of trailing commas is that it improves the clarity of diffs when an item is added or removed from an object or array:

        Less clear:

        var foo = {
        -    bar: "baz",
        -    qux: "quux"
        +    bar: "baz"
         };

        More clear:

        var foo = {
             bar: "baz",
        -    qux: "quux",
         };

        Rule Details

        This rule enforces consistent use of trailing commas in object and array literals.

        Options

        This rule has a string option or an object option:

        {
            "comma-dangle": ["error", "never"],
            // or
            "comma-dangle": ["error", {
                "arrays": "never",
                "objects": "never",
                "imports": "never",
                "exports": "never",
                "functions": "ignore",
            }]
        }
        • "never" (default) disallows trailing commas
        • "always" requires trailing commas
        • "always-multiline" requires trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }
        • "only-multiline" allows (but does not require) trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }

        Trailing commas in function declarations and function calls are valid syntax since ECMAScript 2017; however, the string option does not check these situations for backwards compatibility.

        You can also use an object option to configure this rule for each type of syntax. Each of the following options can be set to "never", "always", "always-multiline", "only-multiline", or "ignore". The default for each option is "never" unless otherwise specified.

        • arrays is for array literals and array patterns of destructuring. (e.g. let [a,] = [1,];)
        • objects is for object literals and object patterns of destructuring. (e.g. let {a,} = {a: 1};)
        • imports is for import declarations of ES Modules. (e.g. import {a,} from "foo";)
        • exports is for export declarations of ES Modules. (e.g. export {a,};)
        • functions is for function declarations and function calls. (e.g. (function(a,){ })(b,);)
          functions is set to "ignore" by default for consistency with the string option.

        never

        Examples of incorrect code for this rule with the default "never" option:

        /*eslint comma-dangle: ["error", "never"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var arr = [1,2,];
        
        foo({
          bar: "baz",
          qux: "quux",
        });

        Examples of correct code for this rule with the default "never" option:

        /*eslint comma-dangle: ["error", "never"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var arr = [1,2];
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        always

        Examples of incorrect code for this rule with the "always" option:

        /*eslint comma-dangle: ["error", "always"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var arr = [1,2];
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        Examples of correct code for this rule with the "always" option:

        /*eslint comma-dangle: ["error", "always"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var arr = [1,2,];
        
        foo({
          bar: "baz",
          qux: "quux",
        });

        always-multiline

        Examples of incorrect code for this rule with the "always-multiline" option:

        /*eslint comma-dangle: ["error", "always-multiline"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var foo = { bar: "baz", qux: "quux", };
        
        var arr = [1,2,];
        
        var arr = [1,
            2,];
        
        var arr = [
            1,
            2
        ];
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        Examples of correct code for this rule with the "always-multiline" option:

        /*eslint comma-dangle: ["error", "always-multiline"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var foo = {bar: "baz", qux: "quux"};
        var arr = [1,2];
        
        var arr = [1,
            2];
        
        var arr = [
            1,
            2,
        ];
        
        foo({
          bar: "baz",
          qux: "quux",
        });

        only-multiline

        Examples of incorrect code for this rule with the "only-multiline" option:

        /*eslint comma-dangle: ["error", "only-multiline"]*/
        
        var foo = { bar: "baz", qux: "quux", };
        
        var arr = [1,2,];
        
        var arr = [1,
            2,];

        Examples of correct code for this rule with the "only-multiline" option:

        /*eslint comma-dangle: ["error", "only-multiline"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var foo = {bar: "baz", qux: "quux"};
        var arr = [1,2];
        
        var arr = [1,
            2];
        
        var arr = [
            1,
            2,
        ];
        
        var arr = [
            1,
            2
        ];
        
        foo({
          bar: "baz",
          qux: "quux",
        });
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        functions

        Examples of incorrect code for this rule with the {"functions": "never"} option:

        /*eslint comma-dangle: ["error", {"functions": "never"}]*/
        
        function foo(a, b,) {
        }
        
        foo(a, b,);
        new foo(a, b,);

        Examples of correct code for this rule with the {"functions": "never"} option:

        /*eslint comma-dangle: ["error", {"functions": "never"}]*/
        
        function foo(a, b) {
        }
        
        foo(a, b);
        new foo(a, b);

        Examples of incorrect code for this rule with the {"functions": "always"} option:

        /*eslint comma-dangle: ["error", {"functions": "always"}]*/
        
        function foo(a, b) {
        }
        
        foo(a, b);
        new foo(a, b);

        Examples of correct code for this rule with the {"functions": "always"} option:

        /*eslint comma-dangle: ["error", {"functions": "always"}]*/
        
        function foo(a, b,) {
        }
        
        foo(a, b,);
        new foo(a, b,);

        When Not To Use It

        You can turn this rule off if you are not concerned with dangling commas. Source: http://eslint.org/docs/rules/

        Unexpected trailing comma.
        Open

                  reporter : 'spec',
        Severity: Minor
        Found in Gruntfile.js by eslint

        require or disallow trailing commas (comma-dangle)

        Trailing commas in object literals are valid according to the ECMAScript 5 (and ECMAScript 3!) spec. However, IE8 (when not in IE8 document mode) and below will throw an error when it encounters trailing commas in JavaScript.

        var foo = {
            bar: "baz",
            qux: "quux",
        };

        Trailing commas simplify adding and removing items to objects and arrays, since only the lines you are modifying must be touched. Another argument in favor of trailing commas is that it improves the clarity of diffs when an item is added or removed from an object or array:

        Less clear:

        var foo = {
        -    bar: "baz",
        -    qux: "quux"
        +    bar: "baz"
         };

        More clear:

        var foo = {
             bar: "baz",
        -    qux: "quux",
         };

        Rule Details

        This rule enforces consistent use of trailing commas in object and array literals.

        Options

        This rule has a string option or an object option:

        {
            "comma-dangle": ["error", "never"],
            // or
            "comma-dangle": ["error", {
                "arrays": "never",
                "objects": "never",
                "imports": "never",
                "exports": "never",
                "functions": "ignore",
            }]
        }
        • "never" (default) disallows trailing commas
        • "always" requires trailing commas
        • "always-multiline" requires trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }
        • "only-multiline" allows (but does not require) trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }

        Trailing commas in function declarations and function calls are valid syntax since ECMAScript 2017; however, the string option does not check these situations for backwards compatibility.

        You can also use an object option to configure this rule for each type of syntax. Each of the following options can be set to "never", "always", "always-multiline", "only-multiline", or "ignore". The default for each option is "never" unless otherwise specified.

        • arrays is for array literals and array patterns of destructuring. (e.g. let [a,] = [1,];)
        • objects is for object literals and object patterns of destructuring. (e.g. let {a,} = {a: 1};)
        • imports is for import declarations of ES Modules. (e.g. import {a,} from "foo";)
        • exports is for export declarations of ES Modules. (e.g. export {a,};)
        • functions is for function declarations and function calls. (e.g. (function(a,){ })(b,);)
          functions is set to "ignore" by default for consistency with the string option.

        never

        Examples of incorrect code for this rule with the default "never" option:

        /*eslint comma-dangle: ["error", "never"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var arr = [1,2,];
        
        foo({
          bar: "baz",
          qux: "quux",
        });

        Examples of correct code for this rule with the default "never" option:

        /*eslint comma-dangle: ["error", "never"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var arr = [1,2];
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        always

        Examples of incorrect code for this rule with the "always" option:

        /*eslint comma-dangle: ["error", "always"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var arr = [1,2];
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        Examples of correct code for this rule with the "always" option:

        /*eslint comma-dangle: ["error", "always"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var arr = [1,2,];
        
        foo({
          bar: "baz",
          qux: "quux",
        });

        always-multiline

        Examples of incorrect code for this rule with the "always-multiline" option:

        /*eslint comma-dangle: ["error", "always-multiline"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var foo = { bar: "baz", qux: "quux", };
        
        var arr = [1,2,];
        
        var arr = [1,
            2,];
        
        var arr = [
            1,
            2
        ];
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        Examples of correct code for this rule with the "always-multiline" option:

        /*eslint comma-dangle: ["error", "always-multiline"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var foo = {bar: "baz", qux: "quux"};
        var arr = [1,2];
        
        var arr = [1,
            2];
        
        var arr = [
            1,
            2,
        ];
        
        foo({
          bar: "baz",
          qux: "quux",
        });

        only-multiline

        Examples of incorrect code for this rule with the "only-multiline" option:

        /*eslint comma-dangle: ["error", "only-multiline"]*/
        
        var foo = { bar: "baz", qux: "quux", };
        
        var arr = [1,2,];
        
        var arr = [1,
            2,];

        Examples of correct code for this rule with the "only-multiline" option:

        /*eslint comma-dangle: ["error", "only-multiline"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var foo = {bar: "baz", qux: "quux"};
        var arr = [1,2];
        
        var arr = [1,
            2];
        
        var arr = [
            1,
            2,
        ];
        
        var arr = [
            1,
            2
        ];
        
        foo({
          bar: "baz",
          qux: "quux",
        });
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        functions

        Examples of incorrect code for this rule with the {"functions": "never"} option:

        /*eslint comma-dangle: ["error", {"functions": "never"}]*/
        
        function foo(a, b,) {
        }
        
        foo(a, b,);
        new foo(a, b,);

        Examples of correct code for this rule with the {"functions": "never"} option:

        /*eslint comma-dangle: ["error", {"functions": "never"}]*/
        
        function foo(a, b) {
        }
        
        foo(a, b);
        new foo(a, b);

        Examples of incorrect code for this rule with the {"functions": "always"} option:

        /*eslint comma-dangle: ["error", {"functions": "always"}]*/
        
        function foo(a, b) {
        }
        
        foo(a, b);
        new foo(a, b);

        Examples of correct code for this rule with the {"functions": "always"} option:

        /*eslint comma-dangle: ["error", {"functions": "always"}]*/
        
        function foo(a, b,) {
        }
        
        foo(a, b,);
        new foo(a, b,);

        When Not To Use It

        You can turn this rule off if you are not concerned with dangling commas. Source: http://eslint.org/docs/rules/

        Unexpected require().
        Open

          this.paypal  = require('paypal-rest-sdk');
        Severity: Minor
        Found in src/index.js by eslint

        Enforce require() on the top-level module scope (global-require)

        In Node.js, module dependencies are included using the require() function, such as:

        var fs = require("fs");

        While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

        function foo() {
        
            if (condition) {
                var fs = require("fs");
            }
        }

        Since require() does a synchronous load, it can cause performance problems when used in other locations.

        Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

        Rule Details

        This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

        Examples of incorrect code for this rule:

        /*eslint global-require: "error"*/
        /*eslint-env es6*/
        
        // calling require() inside of a function is not allowed
        function readFile(filename, callback) {
            var fs = require('fs');
            fs.readFile(filename, callback)
        }
        
        // conditional requires like this are also not allowed
        if (DEBUG) { require('debug'); }
        
        // a require() in a switch statement is also flagged
        switch(x) { case '1': require('1'); break; }
        
        // you may not require() inside an arrow function body
        var getModule = (name) => require(name);
        
        // you may not require() inside of a function body as well
        function getModule(name) { return require(name); }
        
        // you may not require() inside of a try/catch block
        try {
            require(unsafeModule);
        } catch(e) {
            console.log(e);
        }

        Examples of correct code for this rule:

        /*eslint global-require: "error"*/
        
        // all these variations of require() are ok
        require('x');
        var y = require('y');
        var z;
        z = require('z').initialize();
        
        // requiring a module and using it in a function is ok
        var fs = require('fs');
        function readFile(filename, callback) {
            fs.readFile(filename, callback)
        }
        
        // you can use a ternary to determine which module to require
        var logger = DEBUG ? require('dev-logger') : require('logger');
        
        // if you want you can require() at the end of your module
        function doSomethingA() {}
        function doSomethingB() {}
        var x = require("x"),
            z = require("z");

        When Not To Use It

        If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

        Severity
        Category
        Status
        Source
        Language